You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2023/03/08 06:16:07 UTC
[GitHub] [druid] clintropolis opened a new pull request, #13900: fix KafkaInputFormat when used with Sampler API
clintropolis opened a new pull request, #13900:
URL: https://github.com/apache/druid/pull/13900
Fixes #13879.
### Description
Fixes issues when using `KafkaInputFormat` with the sampler API. My initial assessment in #13879 was only partially correct. The implementation of the `sample` method in `KafkaInputReader` also wasn't really correct since by just using the normal read path it did not correctly capture `ParseException` and so would fail immediately. I've adjusted the `sample` method to delegate to the underlying readers `sample`, which will correctly handle these, and changed the blending to occur on the `InputRowListPlusRawValues` of the underlying sample call instead.
#### Release note
The `KafkaInputFormat` now supports using the sampler API `/druid/indexer/v1/sampler`.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #13900: fix KafkaInputFormat when used with Sampler API
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #13900:
URL: https://github.com/apache/druid/pull/13900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org