[GitHub] zhaoyongjie commented on a change in pull request #5070: [bugfix] control override vaule by section

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #5070: [bugfix] control override vaule by section
URL: https://github.com/apache/incubator-superset/pull/5070#discussion_r191077736
 
 

 ##########
 File path: superset/assets/src/explore/components/ControlPanelsContainer.jsx
 ##########
 @@ -89,17 +89,23 @@ class ControlPanelsContainer extends React.Component {
   }
   render() {
     const allSectionsToRender = this.sectionsToRender();
+    const controlOverrides = visTypes[this.props.controls.viz_type.value].controlOverrides || {};
     const querySectionsToRender = [];
     const displaySectionsToRender = [];
     allSectionsToRender.forEach((section) => {
       if (section.controlSetRows.some(rows => rows.some(
-        control => (
-          controls[control] &&
-          (
-            !controls[control].renderTrigger ||
-            controls[control].tabOverride === 'data'
-          )
-        )))) {
+        (control) => {
 
 Review comment:
   hi, @mistercrunch, querySectionsToRender and displaySectionsToRender is dependent on renderTrigger/tabOverride properties in every control object,
   before implement control override in VizType can not do overide here.
   you can test this in Histogram diagram

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org