You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stephen Colebourne <sc...@btopenworld.com> on 2004/01/11 12:39:56 UTC

[collections] RC1 Maven site for review

http://jakarta.apache.org/~scolebourne/collections3/
(link to Javadoc for 3.0 isn't there yet....)

Comments/changes/opinions?

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by __matthewHawthorne <ma...@phreaker.net>.
Tim O'Brien wrote:
> How does the group feel about axing StatCVS reports from Jakarta Commons 
> entirely.  They are a rendering nightmare (takes too long), and they 
> encourage metric gather that is not entirely helpful.  Does it really 
> matter that psteitz is a 7% committer, and that scole... is a 40% 
> committer.  Are we racing?

The StatCVS report for commons-collections takes an ungodly amount of 
time to run.  I always comment it out in my local copy when I make any 
updates.  I'd be +1 to getting rid of it for this reason.

I do, however, like the information that it presents.  I don't think 
we're racing -- but it is informative to see the amount of contribution 
from different committers.  We're already getting rid of @author tags -- 
so it's becoming harder to distinguish one project committer from another.

This may go against the Apache philosophy, but I do *not* think that all 
committers on a project are equal.  I think that those who do more of 
the work should have more weight -- and that's usually the way it works 
out anyway.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Tim O'Brien <to...@discursive.com>.
Janek Bogucki wrote:

>#2
>
>On
>http://jakarta.apache.org/~scolebourne/collections3/license.html
>
>the 'StatCvs Report' link is broken. It links to
>
>http://jakarta.apache.org/~scolebourne/collections3/statcvs/index.html
>
>  
>

How does the group feel about axing StatCVS reports from Jakarta Commons 
entirely.  They are a rendering nightmare (takes too long), and they 
encourage metric gather that is not entirely helpful.  Does it really 
matter that psteitz is a 7% committer, and that scole... is a 40% 
committer.  Are we racing?

Tim

>-Janek
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
>  
>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Tim O'Brien <to...@discursive.com>.
Stephen, that CSS for the white banner background has been committed. 

Maven 1.0 RC1 uses tigris.css and maven.css, xdoc/style/project.css, 
simply overrides the banner colors.

I didn't publish the site, I'll leave that to you.

Cheers.

Tim


Stephen Colebourne wrote:

>From: "Janek Bogucki" <ya...@studylink.com>
>  
>
>>On
>>    
>>
>http://jakarta.apache.org/~scolebourne/collections3/xref/org/apache/commons/
>collections/functors/FunctorUtils.html
>  
>
>>the 'View Javadoc' link, top left, is broken. It links to
>>    
>>
>http://jakarta.apache.org/~scolebourne/collections3/apidocs/org/apache/commo
>ns/collections/functors/FunctorUtils.html
>
>This is correct, as I am only outputting public scoped classes/methods in
>the javadoc, whereas FunctorUtils is package scoped.
>
>
>  
>
>>#2
>>
>>On
>>http://jakarta.apache.org/~scolebourne/collections3/license.html
>>the 'StatCvs Report' link is broken. It links to
>>http://jakarta.apache.org/~scolebourne/collections3/statcvs/index.html
>>    
>>
>Statcvs has obviuosly always failed on my box. I'll take a look
>
>Stephen
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
>  
>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Stephen Colebourne <sc...@btopenworld.com>.
From: "Janek Bogucki" <ya...@studylink.com>
> On
http://jakarta.apache.org/~scolebourne/collections3/xref/org/apache/commons/
collections/functors/FunctorUtils.html
>
> the 'View Javadoc' link, top left, is broken. It links to
http://jakarta.apache.org/~scolebourne/collections3/apidocs/org/apache/commo
ns/collections/functors/FunctorUtils.html

This is correct, as I am only outputting public scoped classes/methods in
the javadoc, whereas FunctorUtils is package scoped.


> #2
>
> On
> http://jakarta.apache.org/~scolebourne/collections3/license.html
> the 'StatCvs Report' link is broken. It links to
> http://jakarta.apache.org/~scolebourne/collections3/statcvs/index.html
Statcvs has obviuosly always failed on my box. I'll take a look

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Janek Bogucki <ya...@studylink.com>.
On Sun, 2004-01-11 at 06:39, Stephen Colebourne wrote:
> http://jakarta.apache.org/~scolebourne/collections3/
> (link to Javadoc for 3.0 isn't there yet....)
> 
> Comments/changes/opinions?
> 
> Stephen

Couple of link nits:

#1

On
http://jakarta.apache.org/~scolebourne/collections3/xref/org/apache/commons/collections/functors/FunctorUtils.html

the 'View Javadoc' link, top left, is broken. It links to

http://jakarta.apache.org/~scolebourne/collections3/apidocs/org/apache/commons/collections/functors/FunctorUtils.html

Also on this page are these broken links:

    http://www.apache.org/).
    http://www.apache.org/>.

but that's a maven thing I guess.


#2

On
http://jakarta.apache.org/~scolebourne/collections3/license.html

the 'StatCvs Report' link is broken. It links to

http://jakarta.apache.org/~scolebourne/collections3/statcvs/index.html

-Janek


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Stephen Colebourne <sc...@btopenworld.com>.
> > I prefer to leave these maven sections in. Simply for maven consistency
> > across all maven websites.
>
> OK, but can we limit reports on the public site to JavaDocs, Unit Tests,
> Sourc XRef, Test XRef and License?  These are more or less stable.
>
> Notice that I left out checkstyle ;)  We should probably add a
> checkstyle.xml reflecting current practices and put some effort into
> cleaning up the stuff that we actually care about. Either that or we
> should just eliminate this report entirely.  I will volunteer to help with
> the cleanup if we decide to do this prior to release; but I would also be
> OK moving forward with the code as is.  The vast majority of problems
> being reported by the current (maven plugin default?) checks are just
> formatting.

I must admit to not having read the checkstyle report. I'd rather get the
release out, than fix anything though. I guess I'm neutral on whether to
keep the report in.

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Phil Steitz <ph...@steitz.com>.
Stephen Colebourne wrote:
> From: "Phil Steitz" <ph...@steitz.com>
> 
>>* Do we really need to show links to every commons/sandbox component?
>>   Might the link to Components.html suffice by itself?
> 
> I think I still prefer the component list at the moment. So long as the
> useful links are manually placed at the top. I think that I've achieved
> that, but if anyone wants to argue for any others, thats fine.

Fine, we just need to keep updating/pushing for now as links change.
> 
> 
>>* Given that the javadoc is available directly, I don't see a lot
>>   of value in including the Project Reports on the public site.
>>   This stuff goes out of date quickly and I don't see us updating
>>   the sight nightly.  Some of the reports (e.g. checkstyle) are
>>   also quite large.
> 
> I prefer to leave these maven sections in. Simply for maven consistency
> across all maven websites.

OK, but can we limit reports on the public site to JavaDocs, Unit Tests,
Sourc XRef, Test XRef and License?  These are more or less stable.

Notice that I left out checkstyle ;)  We should probably add a 
checkstyle.xml reflecting current practices and put some effort into 
cleaning up the stuff that we actually care about. Either that or we 
should just eliminate this report entirely.  I will volunteer to help with 
the cleanup if we decide to do this prior to release; but I would also be 
OK moving forward with the code as is.  The vast majority of problems 
being reported by the current (maven plugin default?) checks are just 
formatting.

Phil


> 
> 
>>Arun's name is out of alpha sort order in the team list and still appears
>>on the contributors list.
> 
> Done
> 
> 
>>Several places in the xdoc have things like "<code>SomeCoolThing</code>."
>>Between maven and Mozilla, the end result is that a space is inserted
>>between "SomeCoolThing" and "."  Using <code>SomeCoolThing.</code>, while
>>somewhat illogical, fixes this.
> 
> Done
> 
> 
>>We need to add a logo image of some kind or override the <logo> in
>>../project.xml, since I think this will show up as a broken image ref
>>under IE.
> 
> Needs someone to create an images/ logo.jpg file and check it in.
> Volunteers?
> 
> Stephen
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Stephen Colebourne <sc...@btopenworld.com>.
From: "Tim O'Brien" <to...@discursive.com>
> On Mon, 12 Jan 2004, Stephen Colebourne wrote:
>
> > It looks good in these colours, but the left nav font is larger, so the
> > javadoc lines wrap. They probably just don't need indenting so much, and
> > maybe a minimum width for the column.
> >
> > However, I don't really want to depend on maven HEAD. They need an RC2.
>
> Yes, I'm not +1 on depending on MAVEN HEAD.  Although, I think we should
> take that CSS over the blue background Maven sites.

I'm happy to have the alternate CSS in [collections].

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Tim O'Brien <to...@discursive.com>.
On Mon, 12 Jan 2004, Stephen Colebourne wrote:

> It looks good in these colours, but the left nav font is larger, so the
> javadoc lines wrap. They probably just don't need indenting so much, and
> maybe a minimum width for the column.
> 
> However, I don't really want to depend on maven HEAD. They need an RC2.

Yes, I'm not +1 on depending on MAVEN HEAD.  Although, I think we should 
take that CSS over the blue background Maven sites.

Tim


> 
> Stephen
> 
> ----- Original Message -----
> From: "Tim O'Brien" <to...@discursive.com>
> To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
> Sent: Monday, January 12, 2004 2:33 AM
> Subject: Re: [collections] RC1 Maven site for review
> 
> 
> > Stephen Colebourne wrote:
> >
> > >>We need to add a logo image of some kind or override the <logo> in
> > >>../project.xml, since I think this will show up as a broken image ref
> > >>under IE.
> > >>
> > >>
> > >Needs someone to create an images/ logo.jpg file and check it in.
> > >Volunteers?
> > >
> > >
> > >
> > try this: http://cvs.apache.org/~tobrien/docs/
> >
> > consistent with
> >
> > http://jakarta.apache.org/commons/betwixt/
> > http://jakarta.apache.org/commons/cli/
> > http://jakarta.apache.org/commons/codec/
> > http://jakarta.apache.org/commons/configuration/
> > http://jakarta.apache.org/commons/daemon/
> > http://jakarta.apache.org/commons/latka/
> >
> > If you disagree, feel free to back out those changes.
> >
> > Tim
> >
> >
> >
> > >Stephen
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 
> 

-- 
----------------------
Tim O'Brien
Evanston, IL
(847) 863-7045
tobrien@discursive.com



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Stephen Colebourne <sc...@btopenworld.com>.
It looks good in these colours, but the left nav font is larger, so the
javadoc lines wrap. They probably just don't need indenting so much, and
maybe a minimum width for the column.

However, I don't really want to depend on maven HEAD. They need an RC2.

Stephen

----- Original Message -----
From: "Tim O'Brien" <to...@discursive.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Monday, January 12, 2004 2:33 AM
Subject: Re: [collections] RC1 Maven site for review


> Stephen Colebourne wrote:
>
> >>We need to add a logo image of some kind or override the <logo> in
> >>../project.xml, since I think this will show up as a broken image ref
> >>under IE.
> >>
> >>
> >Needs someone to create an images/ logo.jpg file and check it in.
> >Volunteers?
> >
> >
> >
> try this: http://cvs.apache.org/~tobrien/docs/
>
> consistent with
>
> http://jakarta.apache.org/commons/betwixt/
> http://jakarta.apache.org/commons/cli/
> http://jakarta.apache.org/commons/codec/
> http://jakarta.apache.org/commons/configuration/
> http://jakarta.apache.org/commons/daemon/
> http://jakarta.apache.org/commons/latka/
>
> If you disagree, feel free to back out those changes.
>
> Tim
>
>
>
> >Stephen
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Tim O'Brien <to...@discursive.com>.
On Sun, 11 Jan 2004, __matthewHawthorne wrote:

> Maybe that's the style in Maven's CVS HEAD?  It looks like 
> maven.apache.org ...

It is indeed.  But, I'd suggest that we customize our CSS stylesheets now, 
with a white background for a few reasons:

1. More consistent with existing Jakarta-wide style (if you could say 
there was a Jakarta wide style)

2. More consistent with existing Commons non-Maven builds

3. We should have to change our L+F with ever Maven release. I'm +1 for 
taking the CSS and HTML we have and storing locally.

Tim



> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 
> 

-- 
----------------------
Tim O'Brien
Evanston, IL
(847) 863-7045
tobrien@discursive.com



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by __matthewHawthorne <ma...@phreaker.net>.
Maybe that's the style in Maven's CVS HEAD?  It looks like 
maven.apache.org ...


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Tim O'Brien <to...@discursive.com>.

On Sun, 11 Jan 2004, Phil Steitz wrote:

> Tim O'Brien wrote:
> > Stephen Colebourne wrote:
> > 
> Looks good to me, but the colors, etc. are incorrect when I build locally.
> How/where exactly are you specifying the style stuff?

Was hoping you wouldn't ask.  Building with Maven 1.1.  But, we could 
easily achieve this look and feel if we took the CSS from Maven 1.1 and 
stored it locally in commons.




> 
> Phil
> > 
> > 
> >> Stephen
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >>
> >>
> >>
> >>  
> >>
> > 
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> > 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 
> 

-- 
----------------------
Tim O'Brien
Evanston, IL
(847) 863-7045
tobrien@discursive.com



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Phil Steitz <ph...@steitz.com>.
Tim O'Brien wrote:
> Stephen Colebourne wrote:
> 
>>> We need to add a logo image of some kind or override the <logo> in
>>> ../project.xml, since I think this will show up as a broken image ref
>>> under IE.
>>>   
>>
>> Needs someone to create an images/ logo.jpg file and check it in.
>> Volunteers?
>>
>>  
>>
> try this: http://cvs.apache.org/~tobrien/docs/
> 
> consistent with
> 
> http://jakarta.apache.org/commons/betwixt/
> http://jakarta.apache.org/commons/cli/
> http://jakarta.apache.org/commons/codec/
> http://jakarta.apache.org/commons/configuration/
> http://jakarta.apache.org/commons/daemon/
> http://jakarta.apache.org/commons/latka/
> 
> If you disagree, feel free to back out those changes.
> 
> Tim
> 

Looks good to me, but the colors, etc. are incorrect when I build locally.
How/where exactly are you specifying the style stuff?

Phil
> 
> 
>> Stephen
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>>
>>  
>>
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Tim O'Brien <to...@discursive.com>.
Stephen Colebourne wrote:

>>We need to add a logo image of some kind or override the <logo> in
>>../project.xml, since I think this will show up as a broken image ref
>>under IE.
>>    
>>
>Needs someone to create an images/ logo.jpg file and check it in.
>Volunteers?
>
>  
>
try this: http://cvs.apache.org/~tobrien/docs/

consistent with

http://jakarta.apache.org/commons/betwixt/
http://jakarta.apache.org/commons/cli/
http://jakarta.apache.org/commons/codec/
http://jakarta.apache.org/commons/configuration/
http://jakarta.apache.org/commons/daemon/
http://jakarta.apache.org/commons/latka/

If you disagree, feel free to back out those changes.

Tim



>Stephen
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
>  
>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Stephen Colebourne <sc...@btopenworld.com>.
From: "Phil Steitz" <ph...@steitz.com>
> * Do we really need to show links to every commons/sandbox component?
>    Might the link to Components.html suffice by itself?
I think I still prefer the component list at the moment. So long as the
useful links are manually placed at the top. I think that I've achieved
that, but if anyone wants to argue for any others, thats fine.

> * Given that the javadoc is available directly, I don't see a lot
>    of value in including the Project Reports on the public site.
>    This stuff goes out of date quickly and I don't see us updating
>    the sight nightly.  Some of the reports (e.g. checkstyle) are
>    also quite large.
I prefer to leave these maven sections in. Simply for maven consistency
across all maven websites.

> Arun's name is out of alpha sort order in the team list and still appears
> on the contributors list.
Done

> Several places in the xdoc have things like "<code>SomeCoolThing</code>."
> Between maven and Mozilla, the end result is that a space is inserted
> between "SomeCoolThing" and "."  Using <code>SomeCoolThing.</code>, while
> somewhat illogical, fixes this.
Done

> We need to add a logo image of some kind or override the <logo> in
> ../project.xml, since I think this will show up as a broken image ref
> under IE.
Needs someone to create an images/ logo.jpg file and check it in.
Volunteers?

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Tim O'Brien <to...@discursive.com>.
+1 for removing the distracting list of components from the left nav and 
replacing it with a link to components.html

Also, take a look at the Maven sites with a white background.  Betwixt, 
CLi, codec, configuration, daemon, latka.

src/media/logo.xcf - get a copy of GIMP 1.2, open up the layer's and 
create a logo.

Tim


__matthewHawthorne wrote:

> Phil Steitz wrote:
>
>> * Do we really need to show links to every commons/sandbox component?
>>   Might the link to Components.html suffice by itself?  If we decided
>>   to standardize on this approach, we would not have to worry about
>>   regenerating and redeploying all of the maven sites when new things
>>   are added to the sandbox or things move from the sandbox to the
>>   commons proper. I know that eventually we will have an integrated
>>   maven site, but even then it seems like all of the links on every
>>   page might be overkill.
>
>
>
> I agree with Phil here.  I think this is the incl_nav.xml that is 
> being included in the xdocs/navigation.xml.  This is something that at 
> first I thought was a great idea, but as time went on I'm starting to 
> find it annoying.  For a project like collections (or any other 
> commons project), a simple link back to the Jakarta Commons home page 
> would be enough, I think.
>
> The other bad thing about including the commons navigation is that it 
> bumps the Project Info and Project Reports to the bottom.  This could 
> be considered more of a limitation of Maven, I guess.
>
> Other than that, I think the site looks great, especially the User's 
> Guide. Good job!
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by __matthewHawthorne <ma...@phreaker.net>.
Phil Steitz wrote:
> * Do we really need to show links to every commons/sandbox component?
>   Might the link to Components.html suffice by itself?  If we decided
>   to standardize on this approach, we would not have to worry about
>   regenerating and redeploying all of the maven sites when new things
>   are added to the sandbox or things move from the sandbox to the
>   commons proper. I know that eventually we will have an integrated
>   maven site, but even then it seems like all of the links on every
>   page might be overkill.


I agree with Phil here.  I think this is the incl_nav.xml that is being 
included in the xdocs/navigation.xml.  This is something that at first I 
thought was a great idea, but as time went on I'm starting to find it 
annoying.  For a project like collections (or any other commons 
project), a simple link back to the Jakarta Commons home page would be 
enough, I think.

The other bad thing about including the commons navigation is that it 
bumps the Project Info and Project Reports to the bottom.  This could be 
considered more of a limitation of Maven, I guess.

Other than that, I think the site looks great, especially the User's 
Guide. Good job!


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Phil Steitz <ph...@steitz.com>.
Stephen Colebourne wrote:
> http://jakarta.apache.org/~scolebourne/collections3/
> (link to Javadoc for 3.0 isn't there yet....)
> 
> Comments/changes/opinions?

Looks good in general.  Here are a few comments and nits:

Comment:

I like the nav bar setup (most relevant stuff on top), but I am wondering 
whether we need some of the stuff at the bottom at all.  Specifically,

* Do we really need to show links to every commons/sandbox component?
   Might the link to Components.html suffice by itself?  If we decided
   to standardize on this approach, we would not have to worry about
   regenerating and redeploying all of the maven sites when new things
   are added to the sandbox or things move from the sandbox to the
   commons proper. I know that eventually we will have an integrated
   maven site, but even then it seems like all of the links on every
   page might be overkill.

* Given that the javadoc is available directly, I don't see a lot
   of value in including the Project Reports on the public site.
   This stuff goes out of date quickly and I don't see us updating
   the sight nightly.  Some of the reports (e.g. checkstyle) are
   also quite large.

Nits:

Arun's name is out of alpha sort order in the team list and still appears 
on the contributors list.

Several places in the xdoc have things like "<code>SomeCoolThing</code>." 
Between maven and Mozilla, the end result is that a space is inserted 
between "SomeCoolThing" and "."  Using <code>SomeCoolThing.</code>, while 
somewhat illogical, fixes this.

We need to add a logo image of some kind or override the <logo> in
../project.xml, since I think this will show up as a broken image ref 
under IE.

Phil






---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Stephen Colebourne <sc...@btopenworld.com>.
From: "Janek Bogucki" <ya...@studylink.com>
> On
> http://jakarta.apache.org/~scolebourne/collections3/
>
> the link, top right, 'Collections', is broken, It links to
> http://jakarta.apache.org/commons/collections/index.html
>
> (At first I didn't see the link - it's blue on a blue background.)
>
> The current link from http://jakarta.apache.org/commons/index.html to
> the current collections home page is
> http://jakarta.apache.org/commons/collections.html. Maybe it is
> http://jakarta.apache.org/commons/index.html that will need to change.

This is correct, as it will be the correct link once the maven site is live.

Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [collections] RC1 Maven site for review

Posted by Janek Bogucki <ya...@studylink.com>.
On Sun, 2004-01-11 at 06:39, Stephen Colebourne wrote:
> http://jakarta.apache.org/~scolebourne/collections3/
> (link to Javadoc for 3.0 isn't there yet....)
> 
> Comments/changes/opinions?
> 
> Stephen

One more link nit:

On
http://jakarta.apache.org/~scolebourne/collections3/

the link, top right, 'Collections', is broken, It links to
http://jakarta.apache.org/commons/collections/index.html

(At first I didn't see the link - it's blue on a blue background.)

The current link from http://jakarta.apache.org/commons/index.html to
the current collections home page is
http://jakarta.apache.org/commons/collections.html. Maybe it is
http://jakarta.apache.org/commons/index.html that will need to change.

-Janek


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org