DO NOT REPLY [Bug 24516] New: - excessive input issue and javascript tag extensibility

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24516>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24516

excessive input issue and javascript tag extensibility

           Summary: excessive input issue and javascript tag extensibility
           Product: Struts
           Version: 1.1 Final
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Validator Framework
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: rvh3@comcast.net


I work on an application that is being converted to Struts.  One of the pages
has a LARGE number of input tags.  And it is using a custom validator based on
the existing html validation tag.

First issue:  The method getNextVar(String input) generates successive
2-character, lower-case variable names to be used in the Javascript code.  This
problem is that the variable name 'do' is reserved (even when preceeded by
'this.').  I refactored getNextVar to deal with a VAR_PREFIX (="_") and
VAR_BASE_NAME (="aa").  This allowed my co-worker to get to the number of input
variables required to validate the page ("gd").

Second issue:  Related to extending the html javascript tag, a few methods and
attributes were private (htmlBeginComment, htmlEndComment, getNextVar(),
getStartElement(), isXhtml(), replaceChar()).  Except for replaceChar() (which I
commented out -- only used by the old getNextVar(), I have made these protected.
 Suggest that the attributes (and the new attributes I added) be hidden behind
accessors.

Attaching a diff file of these changes in my reply.

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org