[GitHub] [activemq-artemis] gtully commented on a change in pull request #3418: ARTEMIS-3064 - ensure useTopologyForLoadBalancing is disabled when ha…

[GitBox <gi...@apache.org>]

gtully commented on a change in pull request #3418:
URL: https://github.com/apache/activemq-artemis/pull/3418#discussion_r563843155



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/FederationConnection.java
##########
@@ -69,6 +69,10 @@ public FederationConnection(Configuration configuration, String name, Federation
          }
       }
 
+      if (!config.isHA()) {
+         serverLocator.setUseTopologyForLoadBalancing(false);

Review comment:
       interesting, https://issues.apache.org/jira/browse/ARTEMIS-347 introduces a cluster-connection-url in place of a connector-ref. The configuration is now a choice.
   Maybe we can deprecate all of the server locator config for federation and just use a url? Or do we need to retain a choice? I think the server locator url parser is smart enough to cover all options w.r.t discovery groups etc.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org