You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ponymail.apache.org by GitBox <gi...@apache.org> on 2021/09/25 10:47:19 UTC

[GitHub] [incubator-ponymail-foal] sebbASF opened a new issue #87: Should not use assert for validating user data

sebbASF opened a new issue #87:
URL: https://github.com/apache/incubator-ponymail-foal/issues/87


   The assert statement is intended for checking internal code consistency, not validating user input.
   
   Assertions can be switched off, but user input validation is always required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #87: Should not use assert for validating user data

Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #87:
URL: https://github.com/apache/incubator-ponymail-foal/issues/87#issuecomment-1030941949


   AFAICT all the questionable usages have been replaced.
   
   If assertions are disabled, the code will still fail, but possibly less gracefully.
   
   Note that assert is helpful in co-operation with mypy checking as it can be used to suppress reports of possible null usage


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #87: Should not use assert for validating user data

Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #87:
URL: https://github.com/apache/incubator-ponymail-foal/issues/87#issuecomment-938174198


   This applies to quite a few scripts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ponymail-foal] sebbASF closed issue #87: Should not use assert for validating user data

Posted by GitBox <gi...@apache.org>.
sebbASF closed issue #87:
URL: https://github.com/apache/incubator-ponymail-foal/issues/87


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #87: Should not use assert for validating user data

Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #87:
URL: https://github.com/apache/incubator-ponymail-foal/issues/87#issuecomment-938174198


   This applies to quite a few scripts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org