You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/01 04:36:44 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #5394: ui: Fetch all records && honour default.ui.page.size
davidjumani opened a new pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394
Fixes https://github.com/apache/cloudstack/issues/5338 && #3121
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani removed a comment on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911454523
@rhtyd Fixing #3121 has some code overlap with fixing #5338, so it is easier to get two issues fixed at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-909959780
@davidjumani pl remove changes for 3121, I can't accept too many core UI changes closer to the RC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-909878701
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5394 (SL-JID-586)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-912246804
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5394 (SL-JID-598)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-909959780
@davidjumani pl remove changes for 3121, I can't accept too many core UI changes closer to the RC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-912348393
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#discussion_r699891329
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Review comment:
If config key exists we shouldn't need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-909876891
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#discussion_r700101972
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Review comment:
Yes, will make the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911454523
@rhtyd Fixing #3121 has some code overlap with fixing #5338, so it is easier to get two issues fixed at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911465269
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#discussion_r699839718
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Review comment:
@davidjumani won't we have to create a 41510to41520 upgrade for it to work for 4.15.1 to 4.15.2 upgrade?
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Review comment:
@davidjumani won't we have to create a 41510to41520 upgrade path for it to work for 4.15.1 to 4.15.2 upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-912244137
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#discussion_r699891329
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Review comment:
If config key exists we shouldn't need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-912341824
Need one more review/test - @davidjumani @shwstppr @nvazquez @sureshanaparti...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911475251
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5394 (SL-JID-593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-909876891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911778291
@davidjumani check latest 4.15, upgrade path is now available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-912348055
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-910201361
Converting to draft until the sql code is moved to the right path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-909876770
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-912381425
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#discussion_r699839718
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Review comment:
@davidjumani won't we have to create a 41510to41520 upgrade for it to work for 4.15.1 to 4.15.2 upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911390976
@davidjumani can you only keep changes strictly for #5338 and remove any other changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-912245422
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911464859
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-911454523
@rhtyd Fixing #5338 also partially fixes #3121 as well, so it is easier to get two issues fixed at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#issuecomment-909876770
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5394: ui: Fetch all records && honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394#discussion_r699839718
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql
##########
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers
-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);
+
+UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Review comment:
@davidjumani won't we have to create a 41510to41520 upgrade path for it to work for 4.15.1 to 4.15.2 upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5394: ui: Honour default.ui.page.size
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5394:
URL: https://github.com/apache/cloudstack/pull/5394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org