[GitHub] [iceberg] rdblue commented on a diff in pull request #6335: Core: Avoid generating a large ManifestFile when committing

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6335:
URL: https://github.com/apache/iceberg/pull/6335#discussion_r1051687190


##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -896,33 +903,27 @@ private Iterable<ManifestFile> prepareNewManifests() {
         manifest -> GenericManifestFile.copyOf(manifest).withSnapshotId(snapshotId()).build());
   }
 
-  private ManifestFile newFilesAsManifest() {
-    if (hasNewFiles && cachedNewManifest != null) {
-      deleteFile(cachedNewManifest.path());
-      cachedNewManifest = null;
+  private List<ManifestFile> newFilesAsManifest() {

Review Comment:
   This should also fix method naming. If a method returns more than one item, it should be plural.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org