You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/26 02:58:50 UTC
[GitHub] [spark] viirya opened a new pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
viirya opened a new pull request #31656:
URL: https://github.com/apache/spark/pull/31656
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch proposes to remove unnecessary children from Union under Distince and Deduplicate
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
If there are any duplicate child of `Union` under `Distinct` and `Deduplicate`, it can be removed to simplify query plan.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r583607931
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -157,8 +157,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
// since the other rules might make two separate Unions operators adjacent.
Batch("Union", Once,
RemoveNoopOperators,
- RemoveNoopUnion,
- CombineUnions) ::
+ CombineUnions,
+ RemoveNoopUnion) ::
Review comment:
Does the added test in `DataFrameSetOperationsSuite` fail without this reorder? The change itself looks reasonable though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786421442
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40066/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786393905
**[Test build #135486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135486/testReport)** for PR 31656 at commit [`d57c258`](https://github.com/apache/spark/commit/d57c258440a4e3119f2d4a7a151444134f84e91d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786393905
**[Test build #135486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135486/testReport)** for PR 31656 at commit [`d57c258`](https://github.com/apache/spark/commit/d57c258440a4e3119f2d4a7a151444134f84e91d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r584493655
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala
##########
@@ -860,6 +860,22 @@ class DataFrameSetOperationsSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("SPARK-34548: Remove unnecessary children from Union") {
+ Seq(RemoveNoopUnion.ruleName, "").map { ruleName =>
+ withSQLConf(SQLConf.OPTIMIZER_EXCLUDED_RULES.key -> ruleName) {
+ val testData_2 = spark.sparkContext.parallelize(
Review comment:
Renamed to `testDataCopy`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786405847
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40066/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787920836
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135583/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786421442
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40066/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786680662
**[Test build #135503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135503/testReport)** for PR 31656 at commit [`32ac35a`](https://github.com/apache/spark/commit/32ac35ad5a8eb472adc8055927616a433ee04df6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787920836
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135583/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-789364090
Shall we revert?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r584017423
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -526,21 +527,29 @@ object RemoveNoopUnion extends Rule[LogicalPlan] {
case _ => plan
}
- private def removeUnion(u: Union): Option[LogicalPlan] = {
- val unionChildren = u.children.map(removeAliasOnlyProject)
- if (unionChildren.tail.forall(unionChildren.head.sameResult(_))) {
- Some(u.children.head)
+ private def simplifyUnion(u: Union): LogicalPlan = {
+ val uniqueChildren = mutable.ArrayBuffer.empty[LogicalPlan]
+ val uniqueChildrenKey = mutable.HashSet.empty[LogicalPlan]
+
+ u.children.foreach { c =>
+ val key = removeAliasOnlyProject(c).canonicalized
Review comment:
We need plan canonicalization here? It looks enough to check if the output is the same just like `LogicalPlan.sameOutput`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786443204
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135486/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786682023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135503/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787745107
**[Test build #135583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135583/testReport)** for PR 31656 at commit [`6a420d4`](https://github.com/apache/spark/commit/6a420d497d91be512ad3e0317756dcc7f96e605d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787768023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40165/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r584016157
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -157,8 +157,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
// since the other rules might make two separate Unions operators adjacent.
Batch("Union", Once,
RemoveNoopOperators,
- RemoveNoopUnion,
- CombineUnions) ::
+ CombineUnions,
+ RemoveNoopUnion) ::
Review comment:
Ah, I see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r583797946
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -157,8 +157,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
// since the other rules might make two separate Unions operators adjacent.
Batch("Union", Once,
RemoveNoopOperators,
- RemoveNoopUnion,
- CombineUnions) ::
+ CombineUnions,
+ RemoveNoopUnion) ::
Review comment:
Added test is fine. But there will be an [error](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135486/testReport/org.apache.spark.sql/SQLQueryTestSuite/subquery_in_subquery_in_set_operations_sql/) of "Once strategy's idempotence is broken for batch Union".
It is because `CombineUnions` might combine two or more `Union` and they have redundant children under `Distinct`. So the rule order `RemoveNoopUnion` -> `CombineUnions` is not idempotence for Once strategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #31656:
URL: https://github.com/apache/spark/pull/31656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r583605452
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -526,21 +527,29 @@ object RemoveNoopUnion extends Rule[LogicalPlan] {
case _ => plan
}
- private def removeUnion(u: Union): Option[LogicalPlan] = {
- val unionChildren = u.children.map(removeAliasOnlyProject)
- if (unionChildren.tail.forall(unionChildren.head.sameResult(_))) {
- Some(u.children.head)
+ private def simplifyUnion(u: Union): LogicalPlan = {
+ val uniqueChildren = mutable.ArrayBuffer.empty[LogicalPlan]
+ val uniqueChildrenKey = mutable.HashSet.empty[LogicalPlan]
Review comment:
We need to keep `LogicalPlan` itself? We cannot use `semanticHash` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787745107
**[Test build #135583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135583/testReport)** for PR 31656 at commit [`6a420d4`](https://github.com/apache/spark/commit/6a420d497d91be512ad3e0317756dcc7f96e605d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-789364780
Sure 👌 , let's fix it quick then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r584496283
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -526,21 +527,29 @@ object RemoveNoopUnion extends Rule[LogicalPlan] {
case _ => plan
}
- private def removeUnion(u: Union): Option[LogicalPlan] = {
- val unionChildren = u.children.map(removeAliasOnlyProject)
- if (unionChildren.tail.forall(unionChildren.head.sameResult(_))) {
- Some(u.children.head)
+ private def simplifyUnion(u: Union): LogicalPlan = {
+ val uniqueChildren = mutable.ArrayBuffer.empty[LogicalPlan]
+ val uniqueChildrenKey = mutable.HashSet.empty[LogicalPlan]
+
+ u.children.foreach { c =>
+ val key = removeAliasOnlyProject(c).canonicalized
Review comment:
`canonicalized` should cover more cases than `sameOutput`. Note that by definition two plans with same `canonicalized` plans will always evaluate to the same result. But their outputs might not be the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786682023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135503/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787760007
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40165/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787733330
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-789364780
Sure 👌 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786580296
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40084/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786540964
**[Test build #135503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135503/testReport)** for PR 31656 at commit [`32ac35a`](https://github.com/apache/spark/commit/32ac35ad5a8eb472adc8055927616a433ee04df6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-789353959
Hi, All.
This seems to break Scala 2.13 build. Please see the master branch and the last commit on this PR.
```
[error] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:550:25: type mismatch;
1040
[error] found : scala.collection.mutable.ArrayBuffer[org.apache.spark.sql.catalyst.plans.logical.LogicalPlan]
1041
[error] required: Seq[org.apache.spark.sql.catalyst.plans.logical.LogicalPlan]
1042
[error] u.copy(children = uniqueChildren)
1043
[error] ^
1044
[error] one error found
1045
[error] (catalyst / Compile / compileIncremental) Compilation failed
1046
[error] Total time: 177 s (02:57), completed Mar 3, 2021 1:24:01 AM
1047
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786591596
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40084/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-789346341
Thanks @maropu @cloud-fan @holdenk
Merging to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786434905
**[Test build #135486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135486/testReport)** for PR 31656 at commit [`d57c258`](https://github.com/apache/spark/commit/d57c258440a4e3119f2d4a7a151444134f84e91d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r583936208
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -526,21 +527,29 @@ object RemoveNoopUnion extends Rule[LogicalPlan] {
case _ => plan
}
- private def removeUnion(u: Union): Option[LogicalPlan] = {
- val unionChildren = u.children.map(removeAliasOnlyProject)
- if (unionChildren.tail.forall(unionChildren.head.sameResult(_))) {
- Some(u.children.head)
+ private def simplifyUnion(u: Union): LogicalPlan = {
+ val uniqueChildren = mutable.ArrayBuffer.empty[LogicalPlan]
+ val uniqueChildrenKey = mutable.HashSet.empty[LogicalPlan]
Review comment:
Oh, rethinking about it, isn't `canonicalized` more reliable? It is less likely, but hash code might collision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787917406
**[Test build #135583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135583/testReport)** for PR 31656 at commit [`6a420d4`](https://github.com/apache/spark/commit/6a420d497d91be512ad3e0317756dcc7f96e605d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787768023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40165/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786443204
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135486/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786414497
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40066/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786540964
**[Test build #135503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135503/testReport)** for PR 31656 at commit [`32ac35a`](https://github.com/apache/spark/commit/32ac35ad5a8eb472adc8055927616a433ee04df6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786564146
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40084/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-789364258
Reverting is okay, but I think it is a easy fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-787763056
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40165/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-789364104
Thanks @dongjoon-hyun. Let me fix it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r584017456
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala
##########
@@ -860,6 +860,22 @@ class DataFrameSetOperationsSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("SPARK-34548: Remove unnecessary children from Union") {
+ Seq(RemoveNoopUnion.ruleName, "").map { ruleName =>
+ withSQLConf(SQLConf.OPTIMIZER_EXCLUDED_RULES.key -> ruleName) {
+ val testData_2 = spark.sparkContext.parallelize(
Review comment:
nit: not `_2` but `_1`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r583934982
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -526,21 +527,29 @@ object RemoveNoopUnion extends Rule[LogicalPlan] {
case _ => plan
}
- private def removeUnion(u: Union): Option[LogicalPlan] = {
- val unionChildren = u.children.map(removeAliasOnlyProject)
- if (unionChildren.tail.forall(unionChildren.head.sameResult(_))) {
- Some(u.children.head)
+ private def simplifyUnion(u: Union): LogicalPlan = {
+ val uniqueChildren = mutable.ArrayBuffer.empty[LogicalPlan]
+ val uniqueChildrenKey = mutable.HashSet.empty[LogicalPlan]
Review comment:
I think `semanticHash` also works. Can use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31656:
URL: https://github.com/apache/spark/pull/31656#issuecomment-786591596
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40084/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org