You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/24 05:53:03 UTC
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1479: Nacos client enhance
Mulavar commented on a change in pull request #1479:
URL: https://github.com/apache/dubbo-go/pull/1479#discussion_r715334400
##########
File path: common/constant/key.go
##########
@@ -167,27 +167,30 @@ const (
)
const (
- NACOS_KEY = "nacos"
- NACOS_DEFAULT_ROLETYPE = 3
- NACOS_CACHE_DIR_KEY = "cacheDir"
- NACOS_LOG_DIR_KEY = "logDir"
- NACOS_BEAT_INTERVAL_KEY = "beatInterval"
- NACOS_ENDPOINT = "endpoint"
- NACOS_SERVICE_NAME_SEPARATOR = ":"
- NACOS_CATEGORY_KEY = "category"
- NACOS_PROTOCOL_KEY = "protocol"
- NACOS_PATH_KEY = "path"
- NACOS_NAMESPACE_ID = "namespaceId"
- NACOS_PASSWORD = "password"
- NACOS_USERNAME = "username"
- NACOS_NOT_LOAD_LOCAL_CACHE = "nacos.not.load.cache"
- NACOS_APP_NAME_KEY = "appName"
- NACOS_REGION_ID_KEY = "regionId"
- NACOS_ACCESS_KEY = "access"
- NACOS_SECRET_KEY = "secret"
- NACOS_OPEN_KMS_KEY = "kms"
- NACOS_UPDATE_THREAD_NUM_KEY = "updateThreadNum"
- NACOS_LOG_LEVEL_KEY = "logLevel"
+ NACOS_KEY = "nacos"
+ NACOS_DEFAULT_ROLETYPE = 3
+ NACOS_CACHE_DIR_KEY = "cacheDir"
+ NACOS_LOG_DIR_KEY = "logDir"
+ NACOS_BEAT_INTERVAL_KEY = "beatInterval"
+ NACOS_ENDPOINT = "endpoint"
+ NACOS_SERVICE_NAME_SEPARATOR = ":"
+ NACOS_CATEGORY_KEY = "category"
+ NACOS_PROTOCOL_KEY = "protocol"
+ NACOS_PATH_KEY = "path"
+ NACOS_NAMESPACE_ID = "namespaceId"
+ NACOS_PASSWORD = "password"
+ NACOS_USERNAME = "username"
+ NACOS_NOT_LOAD_LOCAL_CACHE = "nacos.not.load.cache"
+ NACOS_APP_NAME_KEY = "appName"
+ NACOS_REGION_ID_KEY = "regionId"
+ NACOS_ACCESS_KEY = "access"
+ NACOS_SECRET_KEY = "secret"
+ NACOS_OPEN_KMS_KEY = "kms"
+ NACOS_UPDATE_THREAD_NUM_KEY = "updateThreadNum"
+ NACOS_LOG_LEVEL_KEY = "logLevel"
+ NACOS_Update_Cache_When_Empty = "updateCacheWhenEmpty"
Review comment:
这里常量名的命名方式和其他不一致
##########
File path: common/constant/key.go
##########
@@ -167,27 +167,30 @@ const (
)
const (
- NACOS_KEY = "nacos"
- NACOS_DEFAULT_ROLETYPE = 3
- NACOS_CACHE_DIR_KEY = "cacheDir"
- NACOS_LOG_DIR_KEY = "logDir"
- NACOS_BEAT_INTERVAL_KEY = "beatInterval"
- NACOS_ENDPOINT = "endpoint"
- NACOS_SERVICE_NAME_SEPARATOR = ":"
- NACOS_CATEGORY_KEY = "category"
- NACOS_PROTOCOL_KEY = "protocol"
- NACOS_PATH_KEY = "path"
- NACOS_NAMESPACE_ID = "namespaceId"
- NACOS_PASSWORD = "password"
- NACOS_USERNAME = "username"
- NACOS_NOT_LOAD_LOCAL_CACHE = "nacos.not.load.cache"
- NACOS_APP_NAME_KEY = "appName"
- NACOS_REGION_ID_KEY = "regionId"
- NACOS_ACCESS_KEY = "access"
- NACOS_SECRET_KEY = "secret"
- NACOS_OPEN_KMS_KEY = "kms"
- NACOS_UPDATE_THREAD_NUM_KEY = "updateThreadNum"
- NACOS_LOG_LEVEL_KEY = "logLevel"
+ NACOS_KEY = "nacos"
+ NACOS_DEFAULT_ROLETYPE = 3
+ NACOS_CACHE_DIR_KEY = "cacheDir"
+ NACOS_LOG_DIR_KEY = "logDir"
+ NACOS_BEAT_INTERVAL_KEY = "beatInterval"
+ NACOS_ENDPOINT = "endpoint"
+ NACOS_SERVICE_NAME_SEPARATOR = ":"
+ NACOS_CATEGORY_KEY = "category"
+ NACOS_PROTOCOL_KEY = "protocol"
+ NACOS_PATH_KEY = "path"
+ NACOS_NAMESPACE_ID = "namespaceId"
+ NACOS_PASSWORD = "password"
+ NACOS_USERNAME = "username"
+ NACOS_NOT_LOAD_LOCAL_CACHE = "nacos.not.load.cache"
+ NACOS_APP_NAME_KEY = "appName"
+ NACOS_REGION_ID_KEY = "regionId"
+ NACOS_ACCESS_KEY = "access"
+ NACOS_SECRET_KEY = "secret"
+ NACOS_OPEN_KMS_KEY = "kms"
+ NACOS_UPDATE_THREAD_NUM_KEY = "updateThreadNum"
+ NACOS_LOG_LEVEL_KEY = "logLevel"
+ NACOS_Update_Cache_When_Empty = "updateCacheWhenEmpty"
+ NACOS_LOG_MAX_AGE = "maxAge"
+ NACOS_LOG_Rotate_Time = "rotateTime"
Review comment:
同上
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org