You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/06 06:53:48 UTC

[GitHub] [doris] qidaye commented on a diff in pull request #10622: [fix] substr('', 1, 5) return empty string instead of null

qidaye commented on code in PR #10622:
URL: https://github.com/apache/doris/pull/10622#discussion_r914476360


##########
be/src/vec/functions/function_string.h:
##########
@@ -167,7 +167,7 @@ struct SubstringUtil {
             int str_size = offsets[i] - offsets[i - 1] - 1;
             // return null if start > src.length

Review Comment:
   Please also optimize the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org