You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/16 13:36:47 UTC
[GitHub] [airflow] phigrofi opened a new pull request #7737: Simple API
endpoint to return a DAG's paused state
phigrofi opened a new pull request #7737: Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737
So far it is possible to set the paused state of a DAG via the experimental API. It would be nice to be also able to query the current paused state of a DAG.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7737: Simple API
endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7737: Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-599540217
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7737: Simple API endpoint to
return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7737: Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600469369
Looks good but you have to follow the commit rules-> create a JIRA issue and make sure description and commit title are following that (see the description of the PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600571241
Thanks @phigrofi !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7737:
[AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600571206
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7737: [AIRFLOW-7080] Simple API
endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600631937
> > Ok, thanks for the guidance!
> > Now it seems fine, except the coverage report, but the coverage drop by 54% does not seem valid.
>
> It's OK. Coverage is just guidance. We optimized away some tests to have faster runs and we are only looking (if at all) at it in the master where all tests are always run
@potiuk Should we disable coverage.io if we aren't doing a full run, or do you still think it has some use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] phigrofi commented on issue #7737: Simple API endpoint to
return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
phigrofi commented on issue #7737: Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600466764
@potiuk Ok, Thank you!
I changed the test for the endpoint, that sets the paused status.
First I wanted to have a separate test, but then I could not figure out how to set the paused state of a DAG for the test.
Please check if it makes sense for you this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600635056
@ashb If this is a frequent API request, I will add it to the documentation. In this way, users will be able to use, but we will not have additional code to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600570932
> Ok, thanks for the guidance!
> Now it seems fine, except the coverage report, but the coverage drop by 54% does not seem valid.
It's OK. Coverage is just guidance. We optimized away some tests to have faster runs and we are only looking (if at all) at it in the master where all tests are always run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7737: [AIRFLOW-7080] Simple API
endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600630735
cc @mik-laj -- since this appears to be a common/requested operation is it worth having "direct" endpoints to get/set the pause state in your new proposed API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] phigrofi commented on issue #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
phigrofi commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600564298
Ok, thanks for the guidance!
Now it seems fine, except the coverage report, but the coverage drop by 54% does not seem valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] phigrofi commented on issue #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
phigrofi commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600480835
Ok, done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600495871
And there are some static check failures now :) .. I recommend installing pre-commits :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7737: [AIRFLOW-7080] Simple
API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600637237
> @potiuk Should we disable coverage.io if we aren't doing a full run, or do you still think it has some use?
Well. for now a lot of people use it to see if things are complete. I often wait until the coverage message comes to see at the PR. But I think we will be able to either get rid of it or start using it when we switch to Github Actions. I really hope it can be done soon....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7737: [AIRFLOW-7080]
Simple API endpoint to return a DAG's paused state
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7737: [AIRFLOW-7080] Simple API endpoint to return a DAG's paused state
URL: https://github.com/apache/airflow/pull/7737#issuecomment-600535236
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7737?src=pr&el=h1) Report
> Merging [#7737](https://codecov.io/gh/apache/airflow/pull/7737?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/8bf6a9093db5a051cc891bb8eda035d41c69239d&el=desc) will **decrease** coverage by `54.46%`.
> The diff coverage is `21.62%`.
[](https://codecov.io/gh/apache/airflow/pull/7737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7737 +/- ##
===========================================
- Coverage 86.93% 32.47% -54.47%
===========================================
Files 915 914 -1
Lines 44170 44219 +49
===========================================
- Hits 38401 14361 -24040
- Misses 5769 29858 +24089
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==) | `17.26% <0.00%> (-39.73%)` | :arrow_down: |
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `29.44% <0.00%> (-65.54%)` | :arrow_down: |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `32.17% <0.00%> (-64.29%)` | :arrow_down: |
| [...ders/google/cloud/example\_dags/example\_bigtable.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2JpZ3RhYmxlLnB5) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...s/google/cloud/example\_dags/example\_cloud\_build.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX2J1aWxkLnB5) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...ers/google/cloud/example\_dags/example\_cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX3NxbC5weQ==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...ogle/cloud/example\_dags/example\_cloud\_sql\_query.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX3NxbF9xdWVyeS5weQ==) | `0.00% <ø> (-98.34%)` | :arrow_down: |
| [...ple\_dags/example\_cloud\_storage\_transfer\_service.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX3N0b3JhZ2VfdHJhbnNmZXJfc2VydmljZS5weQ==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...iders/google/cloud/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2NvbXB1dGUucHk=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...s/google/cloud/example\_dags/example\_compute\_igm.py](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2NvbXB1dGVfaWdtLnB5) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| ... and [814 more](https://codecov.io/gh/apache/airflow/pull/7737/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7737?src=pr&el=footer). Last update [8bf6a90...e6885ea](https://codecov.io/gh/apache/airflow/pull/7737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services