[GitHub] [calcite] libenchao commented on a diff in pull request #3268: [CALCITE-5783] Make the TableFunctionScan hintable

["libenchao (via GitHub)" <gi...@apache.org>]

libenchao commented on code in PR #3268:
URL: https://github.com/apache/calcite/pull/3268#discussion_r1231779699


##########
core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java:
##########
@@ -931,6 +937,12 @@ private static class HintCollector extends RelShuttleImpl {
           if (snapshot.getHints().size() > 0) {
             this.hintsCollect.add("Snapshot:" + snapshot.getHints());
           }
+        } else if (other instanceof LogicalTableFunctionScan) {

Review Comment:
   Prefer to use the base class `TableFunctionScan`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org