You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@graphar.apache.org by "tanmoyPaul12 (via GitHub)" <gi...@apache.org> on 2025/12/29 15:43:01 UTC
[PR] [C++][CMake] Fix install/export targets and Windows runtime handling [incubator-graphar]
tanmoyPaul12 opened a new pull request, #819:
URL: https://github.com/apache/incubator-graphar/pull/819
<!--
Thanks for contributing to GraphAr.
If this is your first pull request you can find detailed information on [CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md)
The Apache GraphAr (incubating) community has restrictions on the naming of pr title. You can find instructions in
[CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md#title) too.
-->
Fixes #810
### Reason for this PR
The current CMake installation logic in GraphAr does not reliably support
library distribution and downstream consumption, especially on Windows.
This PR addresses the CMake install and export issues discussed in #810
and makes runtime installation behavior consistent across platforms.
### What changes are included in this PR?
- Remove duplicate and conflicting install logic for the `graphar` target
- Define a single canonical `install(TARGETS graphar ...)` rule
- Ensure headers and CMake package config files are installed correctly
- Fix Windows runtime (DLL) installation issues during `cmake --install`
- Validate installation with MSVC + vcpkg + Apache Arrow
### Are these changes tested?
- Windows 11
- MSVC (Visual Studio 2026)
- CMake + vcpkg
- Apache Arrow installed via vcpkg (arrow[dataset,parquet])
- Verified:
- `cmake --build . --config Release`
- `cmake --install . --config Release`
- Generated headers and CMake config files
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No. This change affects CMake install and packaging behavior only and does not
modify GraphAr APIs or runtime behavior.
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **BREAKING CHANGE: <description>** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either
(a) a security vulnerability,
(b) a bug that caused incorrect or invalid data to be produced, or
(c) a bug that causes a crash (even when the API contract is upheld).
We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **Critical Fix: <description>** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] [C++][CMake] Fix install/export targets and Windows runtime handling [incubator-graphar]
Posted by "tanmoyPaul12 (via GitHub)" <gi...@apache.org>.
tanmoyPaul12 commented on PR #819:
URL: https://github.com/apache/incubator-graphar/pull/819#issuecomment-3710340936
@yangxk1 I’ll update this PR to:
- Ensure install(EXPORT ...) generates usable CMake target files
- Address the RPATH ($ORIGIN) and hybrid linking strategy discussed in the issue
Thanks for the clarification — I’ll follow up with the changes shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] [C++][CMake] Fix install/export targets and Windows runtime handling [incubator-graphar]
Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #819:
URL: https://github.com/apache/incubator-graphar/pull/819#issuecomment-3710129503
Hi @tanmoyPaul12 Thanks for the update! This PR improves the installation paths (especially for Windows), but it doesn't fully resolve #810 yet.
To fully support find_package(GraphAr) and the requested distribution goals, we still need:
1. The install(EXPORT ...) command to actually generate and install the CMake target files.
2. The RPATH configuration (e.g., $ORIGIN) and the hybrid linking strategy mentioned in the issue discussion.
Could you please address these points?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org
Re: [PR] [C++][CMake] Fix install/export targets and Windows runtime handling [incubator-graphar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #819:
URL: https://github.com/apache/incubator-graphar/pull/819#issuecomment-3698062837
## [Codecov](https://app.codecov.io/gh/apache/incubator-graphar/pull/819?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 77.18%. Comparing base ([`bac3630`](https://app.codecov.io/gh/apache/incubator-graphar/commit/bac36306dc981c371e83e3f2003a11c66addc3cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0d11cb8`](https://app.codecov.io/gh/apache/incubator-graphar/commit/0d11cb834b5e9400e1a0465d232bc808b7234492?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #819 +/- ##
============================================
+ Coverage 77.17% 77.18% +0.01%
Complexity 607 607
============================================
Files 84 85 +1
Lines 8854 8858 +4
Branches 1043 1043
============================================
+ Hits 6833 6837 +4
Misses 1781 1781
Partials 240 240
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-graphar/pull/819?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org