You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2018/04/03 08:11:00 UTC

[jira] [Resolved] (WICKET-6547) NPE upon session timeout

     [ https://issues.apache.org/jira/browse/WICKET-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-6547.
--------------------------------
    Resolution: Not A Problem
      Assignee: Sven Meier

These methods are all called from Wicket code, thus a RequestCycle should be present.

I don't see how #isSessionInvalidated() is called from a container session timeout.

> NPE upon session timeout
> ------------------------
>
>                 Key: WICKET-6547
>                 URL: https://issues.apache.org/jira/browse/WICKET-6547
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.29.0
>            Reporter: Rakesh A
>            Assignee: Sven Meier
>            Priority: Major
>
> Wicket 6.29.0 has a fix for https://issues.apache.org/jira/browse/WICKET-6484
> change-set of which can be see at - 
> [https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=blobdiff;f=wicket-core/src/main/java/org/apache/wicket/Session.java;h=21a9432a2c5d5005b215dd5d7c3b15bf87fda0ba;hp=5bab1c6bf5fd60243c7adc8a9a6f248f41f78166;hb=35b9381;hpb=d0967b2312ed999b289566fbdd81eb282ad20c8e]
> Problem I see with this fix is, when session times out there wont be a 
> request cycle, RequestCycle.get() will return NULL and 
> 'isSessionInvalidated()' method call in 
> 'org.apache.wicket.protocol.http.WebSession.invalidate()' will result a NPE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)