You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/06/20 19:03:38 UTC

[GitHub] brodybits opened a new pull request #157: Start 4.2.4 dev & fix CI for Node.js 4

brodybits opened a new pull request #157: Start 4.2.4 dev & fix CI for Node.js 4
URL: https://github.com/apache/cordova-js/pull/157
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   - Mark 4.2.4-dev in package.json
   - Update appveyor.yml & .travis.yml to use npm@5 as a QUICK FIX WORKAROUND for Node.js 4
   
   NOTES:
   - It is **not** acceptable to drop Node.js 4 before next major release.
   - Use of non-master branch in cordova-js seems to cause some problems with cordova-coho. I hope to investigate and resolve this one in the near future. Until then I would like to avoid the need for non-master branch for patches, which implies:
      - avoid major version bump inn this repo unless absolutely necessary
      - need to maintain Node.js support until we resolve the issue with cordova-coho
   
   ### What testing has been done on this change?
   
   These changes were originally part of WIP PR #151 which passes CI, will check CI results of this PR.
   
   ### Checklist
   
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org