You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by chitin <gi...@git.apache.org> on 2016/11/03 08:05:08 UTC

[GitHub] incubator-eagle pull request #602: EAGLE-728 Application can't load applicat...

GitHub user chitin opened a pull request:

    https://github.com/apache/incubator-eagle/pull/602

    EAGLE-728 Application can't load application.properties when running local mode

    EAGLE-728 Application can't load application.properties when running local mode
    - Add property in server config file
    
    https://issues.apache.org/jira/browse/EAGLE-728

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chitin/incubator-eagle EAGLE-728

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #602
    
----
commit 4cf03775e12329207682d4030fb45be6be64c8ca
Author: chitin <ch...@gmail.com>
Date:   2016-11-03T08:02:02Z

    EAGLE-728 Application can't load application.properties when running local mode
    - Add property in server config file
    https://issues.apache.org/jira/browse/EAGLE-728

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #602: EAGLE-728 Application can't load applicat...

Posted by chitin <gi...@git.apache.org>.
Github user chitin closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/602


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #602: EAGLE-728 Application can't load application.pro...

Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on the issue:

    https://github.com/apache/incubator-eagle/pull/602
  
    Reviewed. We should not add application specific level configuration to eagle server configuration. I think we can hard code, and override it if user passes this configuration from web ui.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #602: EAGLE-728 Application can't load application.pro...

Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on the issue:

    https://github.com/apache/incubator-eagle/pull/602
  
    Please close this, I see another PR has been opened for the same issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #602: EAGLE-728 Application can't load application.pro...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:

    https://github.com/apache/incubator-eagle/pull/602
  
    @wujinhu pls. have a look about this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---