You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/01 22:40:07 UTC
Review Request 43065: Fixed a leak of a `ZooKeeperMasterContender` in
a test case.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43065/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
Fixed a leak of a `ZooKeeperMasterContender` in a test case.
Diffs
-----
src/tests/master_contender_detector_tests.cpp 6375586c31b1fd406529bf299dad6e321b945de8
Diff: https://reviews.apache.org/r/43065/diff/
Testing
-------
make check
Note that the new test in https://reviews.apache.org/r/43035 fails if this leak is not fixed, because advancing the clock causes the leaked `GroupProcess` to fire an `expired` event.
Thanks,
Neil Conway
Re: Review Request 43065: Fixed a leak of a
`ZooKeeperMasterContender` in a test case.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43065/#review119312
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 1, 2016, 9:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43065/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 9:40 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a leak of a `ZooKeeperMasterContender` in a test case.
>
>
> Diffs
> -----
>
> src/tests/master_contender_detector_tests.cpp 6375586c31b1fd406529bf299dad6e321b945de8
>
> Diff: https://reviews.apache.org/r/43065/diff/
>
>
> Testing
> -------
>
> make check
>
> Note that the new test in https://reviews.apache.org/r/43035 fails if this leak is not fixed, because advancing the clock causes the leaked `GroupProcess` to fire an `expired` event.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43065: Fixed a leak of a
`ZooKeeperMasterContender` in a test case.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43065/#review117296
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43033, 43065]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 1, 2016, 9:40 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43065/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 9:40 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a leak of a `ZooKeeperMasterContender` in a test case.
>
>
> Diffs
> -----
>
> src/tests/master_contender_detector_tests.cpp 6375586c31b1fd406529bf299dad6e321b945de8
>
> Diff: https://reviews.apache.org/r/43065/diff/
>
>
> Testing
> -------
>
> make check
>
> Note that the new test in https://reviews.apache.org/r/43035 fails if this leak is not fixed, because advancing the clock causes the leaked `GroupProcess` to fire an `expired` event.
>
>
> Thanks,
>
> Neil Conway
>
>