[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6085: fix: null handling of `ScalarValue::Struct`

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #6085:
URL: https://github.com/apache/arrow-datafusion/pull/6085#discussion_r1173926250


##########
datafusion/common/src/scalar.rs:
##########
@@ -5584,6 +5584,87 @@ mod tests {
         }
     }
 
+    #[test]

Review Comment:
   That looks good, I checked current impl
   
   ```
    select struct(1, 2);
   +---------------------------+
   | struct(Int64(1),Int64(2)) |
   +---------------------------+
   | {c0: 1, c1: 2}            |
   +---------------------------+
   1 row in set. Query took 0.002 seconds.
   ❯ select struct(null, 2);
   +-----------------------+
   | struct(NULL,Int64(2)) |
   +-----------------------+
   | {c0: , c1: 2}         |
   +-----------------------+
   1 row in set. Query took 0.003 seconds.
   ❯ select null::struct;
   This feature is not implemented: Unsupported SQL type Custom(ObjectName([Ident { value: "struct", quote_style: None }]), [])
   ```
   
   @crepererum will this fix also address the exception above? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org