You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sl...@apache.org on 2008/11/13 00:09:55 UTC

svn commit: r713552 - in /myfaces/core/branches/2_0_0: api/src/main/java/javax/faces/context/ExternalContext.java impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java

Author: slessard
Date: Wed Nov 12 15:09:54 2008
New Revision: 713552

URL: http://svn.apache.org/viewvc?rev=713552&view=rev
Log:
MYFACES-1938 - Implement ExternalContext.getRequestServerPort

Modified:
    myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/context/ExternalContext.java
    myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java

Modified: myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/context/ExternalContext.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/context/ExternalContext.java?rev=713552&r1=713551&r2=713552&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/context/ExternalContext.java (original)
+++ myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/context/ExternalContext.java Wed Nov 12 15:09:54 2008
@@ -165,9 +165,7 @@
      */
     public int getRequestServerPort()
     {
-        // TODO: JSF 2.0 #28
-        // VALIDATE: Should this be asbtract or throws UnsupportedOperationException? Check with the EG
-        return 0;
+        throw new UnsupportedOperationException();
     }
 
     public abstract String getRequestServletPath();

Modified: myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java?rev=713552&r1=713551&r2=713552&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java (original)
+++ myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/servlet/ServletExternalContextImpl.java Wed Nov 12 15:09:54 2008
@@ -200,6 +200,12 @@
     }
 
     @Override
+    public int getRequestServerPort()
+    {
+        return _servletRequest.getServerPort();
+    }
+
+    @Override
     @SuppressWarnings("unchecked")
     public Iterator<String> getRequestParameterNames()
     {