You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/12/08 20:08:02 UTC
[GitHub] [incubator-hop] mattcasters opened a new pull request #451: Hop 2268
mattcasters opened a new pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451
**PR FOR EVALUATION ONLY!**
This pull request contains a rework of the metadata API under HOP-2268 : Avoid state of metadata by not implementing IVariables
It removes all references of IVariables from the IHopMetadata and *Meta classes like PipelineMeta and WorkflowMeta.
This did require the passing around of IVariables references left and right.
Integration tests are added under parameters_and_variables.
Other things that I wanted for testing and developing the integration tests:
HOP-2279 : Add log channel to the JavaScript action
HOP-2280 : Pipeline and Workflow action dialog: change name after selecting a file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters commented on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-741718270
I agree with the proposal Nicolas.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-742366066
did some tests in the GUI and via hop-run, everything is looking great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment commented on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-742526596
I quickly scanned the code and it looks ok to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment edited a comment on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
nadment edited a comment on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-741318808
1) Some renaming "space" to "variables" is not good
> @return the amount of free swap **variables** in bytes
> when pressing ctrl+**variables**
2) Is it possible to have a clean API?
String environmentSubstitute( String string ) >>> String resolve( String string );
String[] environmentSubstitute( String[] string ) >>> String[] resolve( String[] string );
public String fieldSubstitute( String string, IRowMeta rowMeta, Object[] rowData ) throws HopValueException >>> public String resolve( String string, IRowMeta rowMeta, Object[] rowData ) throws HopValueException
boolean getBooleanValueOfVariable( String name, boolean defaultValue ) >>> boolean getVariableBoolean( String name, boolean defaultValue )
String[] listVariables() >>> String[] getVariableNames();
IVariables getParentVariableSpace() >>> IVariables getParentVariables()
void setParentVariableSpace( IVariables parent ) >>> void setParentVariables( IVariables parent )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment edited a comment on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
nadment edited a comment on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-741318808
Some renaming "space" to "variables" is not good
> @return the amount of free swap **variables** in bytes
> when pressing ctrl+variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters merged pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
mattcasters merged pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment edited a comment on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
nadment edited a comment on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-741318808
1) Some renaming "space" to "variables" is not good
> @return the amount of free swap **variables** in bytes
> when pressing ctrl+**variables**
2) Is it possible to have a clean API for IVariables ?
String environmentSubstitute( String string ) >>> String resolve( String string );
String[] environmentSubstitute( String[] string ) >>> String[] resolve( String[] string );
public String fieldSubstitute( String string, IRowMeta rowMeta, Object[] rowData ) throws HopValueException >>> public String resolve( String string, IRowMeta rowMeta, Object[] rowData ) throws HopValueException
boolean getBooleanValueOfVariable( String name, boolean defaultValue ) >>> boolean getVariableBoolean( String name, boolean defaultValue )
String[] listVariables() >>> String[] getVariableNames();
IVariables getParentVariableSpace() >>> IVariables getParentVariables()
void setParentVariableSpace( IVariables parent ) >>> void setParentVariables( IVariables parent )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment commented on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-741318808
Some renaming "space" to "variables" is not good
> @return the amount of free swap **variables** in bytes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment edited a comment on pull request #451: Hop 2268
Posted by GitBox <gi...@apache.org>.
nadment edited a comment on pull request #451:
URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-741318808
Some renaming "space" to "variables" is not good
> @return the amount of free swap **variables** in bytes
> when pressing ctrl+**variables**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org