You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2019/11/01 22:50:00 UTC

[jira] [Commented] (PHOENIX-5557) Prevent String comparison using ==

    [ https://issues.apache.org/jira/browse/PHOENIX-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965134#comment-16965134 ] 

Hadoop QA commented on PHOENIX-5557:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12984662/PHOENIX-5557.master.000.patch
  against master branch at commit 67d72a222e204f195a206bb6c5973f7e175ef951.
  ATTACHMENT ID: 12984662

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3090//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3090//console

This message is automatically generated.

> Prevent String comparison using ==
> ----------------------------------
>
>                 Key: PHOENIX-5557
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5557
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.1.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0
>
>         Attachments: PHOENIX-5557.master.000.patch
>
>
> UpgradeUtil and SequenceKey have a couple of string comparison use cases with == instead of equals()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)