You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/11/27 03:27:58 UTC

[jira] [Commented] (BOOKKEEPER-470) Possible infinite loop in simple.SubscribeReconnectCallback

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504310#comment-13504310 ] 

Sijie Guo commented on BOOKKEEPER-470:
--------------------------------------

I think the behavior before BOOKKEEPER-70 is that we should do resubscribe until succeed if resubscribe is enabled. If you stopped resubscribing, the subscriber got nothing notified about its subscription is stopped unless it registered listener about it. So I think we should keep this behavior but log some critical messages after a specific retires.
                
> Possible infinite loop in simple.SubscribeReconnectCallback
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-470
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-470
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: 0005-Remove-infinite-loop-from-SubscribeReconnectCallback.patch
>
>
> SubscribeReconnectCallback#operationFailed calls
> SubscribeReconnectCallback#retrySubscribeRequest calls
> channelManager#submitOpAfterDelay calls
> SubscribeReconnectCallback#operationFailed (if closed is true).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira