You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benedict Elliott Smith (Jira)" <ji...@apache.org> on 2023/02/08 22:18:00 UTC

[jira] [Commented] (CASSANDRA-18212) Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue

    [ https://issues.apache.org/jira/browse/CASSANDRA-18212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686117#comment-17686117 ] 

Benedict Elliott Smith commented on CASSANDRA-18212:
----------------------------------------------------

I thought we had discussed either using the {{byte[]}} or casting to {{BufferPoolAllocator.Wrapped}} on slack?

https://the-asf.slack.com/archives/CK23JSY2K/p1675285925529819?thread_ts=1675279019.024139&cid=CK23JSY2K
https://the-asf.slack.com/archives/CK23JSY2K/p1675287376825619?thread_ts=1675279019.024139&cid=CK23JSY2K

> Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18212
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18212
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Local Write-Read Paths
>            Reporter: Natnael Adere
>            Assignee: Natnael Adere
>            Priority: Normal
>         Attachments: DiskBased.png, MemoryBased.png, allocations-after.html, allocations-before.html
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Currently, org.apache.cassandra.transport.CBUtil#writeValue(java.nio.ByteBuffer, io.netty.buffer.ByteBuf) calls ByteBufer.duplicate() and is found to be 20% of memory allocations in production. No changes have been made to reduce this but there is discussion related to the issue in CASSANDRA-13741. Attached below are the performance result for disk based queries and mostly memory based queries. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org