svn commit: r1749883 - /subversion/trunk/subversion/libsvn_subr/cmdline.c

[iv...@apache.org]

Author: ivan
Date: Thu Jun 23 13:13:01 2016
New Revision: 1749883

URL: http://svn.apache.org/viewvc?rev=1749883&view=rev
Log:
Small refactoring.

* subversion/libsvn_subr/cmdline.c
  (most_similar): Initialize MAX_SIMILAR to NULL at the beginning and return
   it directly instead of checking if MAX_SCORE is non-zero.

Modified:
    subversion/trunk/subversion/libsvn_subr/cmdline.c

Modified: subversion/trunk/subversion/libsvn_subr/cmdline.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/cmdline.c?rev=1749883&r1=1749882&r2=1749883&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/cmdline.c (original)
+++ subversion/trunk/subversion/libsvn_subr/cmdline.c Thu Jun 23 13:13:01 2016
@@ -822,7 +822,7 @@ most_similar(const char *needle_cstr,
              apr_size_t haystack_len,
              apr_pool_t *scratch_pool)
 {
-  const char *max_similar;
+  const char *max_similar = NULL;
   apr_size_t max_score = 0;
   apr_size_t i;
   svn_membuf_t membuf;
@@ -847,10 +847,7 @@ most_similar(const char *needle_cstr,
         }
     }
 
-  if (max_score)
-    return max_similar;
-  else
-    return NULL;
+  return max_similar;
 }
 
 /* Verify that NEEDLE is in HAYSTACK, which contains HAYSTACK_LEN elements. */