You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/07/30 23:11:37 UTC

Review Request 13080: No longer accept offers on the same host/port.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13080/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

No longer accept offers on the same host/port.

We'll try to find a port combination that hasn't already been used to
launch a TaskTracker.


Diffs
-----

  hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 69d4655a38c6fd24c19918d240727a43cd1c9c92 

Diff: https://reviews.apache.org/r/13080/diff/


Testing
-------

Used in production at airbnb.

make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3


Thanks,

Brenden Matthews


Re: Review Request 13080: No longer accept offers on the same host/port.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13080/#review24304
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 30, 2013, 9:11 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13080/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 9:11 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> No longer accept offers on the same host/port.
> 
> We'll try to find a port combination that hasn't already been used to
> launch a TaskTracker.
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 69d4655a38c6fd24c19918d240727a43cd1c9c92 
> 
> Diff: https://reviews.apache.org/r/13080/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request 13080: No longer accept offers on the same host/port.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13080/#review24288
-----------------------------------------------------------



hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/13080/#comment48120>

    The indentation is messed up here, but it's fixed in a later commit.


- Brenden Matthews


On July 30, 2013, 9:11 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13080/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 9:11 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> No longer accept offers on the same host/port.
> 
> We'll try to find a port combination that hasn't already been used to
> launch a TaskTracker.
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 69d4655a38c6fd24c19918d240727a43cd1c9c92 
> 
> Diff: https://reviews.apache.org/r/13080/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request 13080: No longer accept offers on the same host/port.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13080/#review24287
-----------------------------------------------------------


This is the same as https://reviews.apache.org/r/11161/

I had to abandon the other change because review board was having difficulties.

- Brenden Matthews


On July 30, 2013, 9:11 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13080/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 9:11 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> No longer accept offers on the same host/port.
> 
> We'll try to find a port combination that hasn't already been used to
> launch a TaskTracker.
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 69d4655a38c6fd24c19918d240727a43cd1c9c92 
> 
> Diff: https://reviews.apache.org/r/13080/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>