You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/24 06:03:57 UTC
[GitHub] [incubator-doris] WingsGo opened a new issue #3935: [Proposal]Unify all frontend config behavior
WingsGo opened a new issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935
**Is your feature request related to a problem? Please describe.**
Currently in FE, we have different config, some of them are master only, so we need to directly connect the master FE to change the settings, and some frontend config is shown different in Master FE and no Master FE, it may leads some confusion, So I think maybe we can let non master fe to forward some master only config to Master FE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo closed issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
WingsGo closed issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
WingsGo commented on issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-649956622
> Hi, I found that it already be implemented.
>
> https://github.com/apache/incubator-doris/blob/5e5696fda2c26bf1f1e0dcc6045b280a314f7fbf/fe/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java#L53-L59
That's great, but it seems only support set frontend config DDL, not include show frontend config?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo edited a comment on issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
WingsGo edited a comment on issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-649956622
> Hi, I found that it already be implemented.
>
> https://github.com/apache/incubator-doris/blob/5e5696fda2c26bf1f1e0dcc6045b280a314f7fbf/fe/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java#L53-L59
That's great, but it seems only support `admin set frontend config` DDL, not include `admin show frontend config`?If we set some master only config in non master node, it will confused us if the config works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-648612449
that would be good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-649379482
Hi, I found that it already be implemented.
https://github.com/apache/incubator-doris/blob/5e5696fda2c26bf1f1e0dcc6045b280a314f7fbf/fe/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java#L53-L59
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
WingsGo commented on issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-650543168
> > That's great, but it seems only support `admin set frontend config` DDL, not include `admin show frontend config`?If we set some master only config in non master node the change will not shown in non master node, it will confused us if the config works?
>
> You should execute `set forward_to_master=true` before executing `admin show frontend config`.
>
> Because sometimes we DO want to know the config value of current connected FE.
Yes, That's what I want, thx~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-650535090
> That's great, but it seems only support `admin set frontend config` DDL, not include `admin show frontend config`?If we set some master only config in non master node the change will not shown in non master node, it will confused us if the config works?
You should execute `set forward_to_master=true` before executing `admin show frontend config`.
Because sometimes we DO want to know the config value of current connected FE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo edited a comment on issue #3935: [Proposal]Unify all frontend config behavior
Posted by GitBox <gi...@apache.org>.
WingsGo edited a comment on issue #3935:
URL: https://github.com/apache/incubator-doris/issues/3935#issuecomment-649956622
> Hi, I found that it already be implemented.
>
> https://github.com/apache/incubator-doris/blob/5e5696fda2c26bf1f1e0dcc6045b280a314f7fbf/fe/src/main/java/org/apache/doris/analysis/AdminSetConfigStmt.java#L53-L59
That's great, but it seems only support `admin set frontend config` DDL, not include `admin show frontend config`?If we set some master only config in non master node the change will not shown in non master node, it will confused us if the config works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org