You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2015/05/07 20:20:54 UTC
Review Request 33950: AURORA-1308 - 0.8.0 changelog contains wontfix
and duplicate ticket references
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33950/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1308
https://issues.apache.org/jira/browse/AURORA-1308
Repository: aurora
Description
-------
AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references
Patch resets rc version and removes changelog entries, updates changelog script to only pull in relevant issues now
Diffs
-----
CHANGELOG 3bc43e10792bc8345e5a29631a4e5248926fdc25
build-support/release/changelog 31fa72dfd850163a7603edcf286099f1bd280d4f
src/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638
Diff: https://reviews.apache.org/r/33950/diff/
Testing
-------
Thanks,
Jake Farrell
Re: Review Request 33950: AURORA-1308 - 0.8.0 changelog contains
wontfix and duplicate ticket references
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33950/#review82864
-----------------------------------------------------------
Can you update the summary to a description of the solution rather than a description of the problem? This shows in the git log.
- Kevin Sweeney
On May 7, 2015, 11:20 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33950/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 11:20 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1308
> https://issues.apache.org/jira/browse/AURORA-1308
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references
>
> Patch resets rc version and removes changelog entries, updates changelog script to only pull in relevant issues now
>
>
> Diffs
> -----
>
> CHANGELOG 3bc43e10792bc8345e5a29631a4e5248926fdc25
> build-support/release/changelog 31fa72dfd850163a7603edcf286099f1bd280d4f
> src/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638
>
> Diff: https://reviews.apache.org/r/33950/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 33950: AURORA-1308 - 0.8.0 changelog contains
wontfix and duplicate ticket references
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33950/#review82865
-----------------------------------------------------------
Master (fef7194) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 7, 2015, 6:20 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33950/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 6:20 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1308
> https://issues.apache.org/jira/browse/AURORA-1308
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references
>
> Patch resets rc version and removes changelog entries, updates changelog script to only pull in relevant issues now
>
>
> Diffs
> -----
>
> CHANGELOG 3bc43e10792bc8345e5a29631a4e5248926fdc25
> build-support/release/changelog 31fa72dfd850163a7603edcf286099f1bd280d4f
> src/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638
>
> Diff: https://reviews.apache.org/r/33950/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 33950: AURORA-1308 - 0.8.0 changelog contains
wontfix and duplicate ticket references
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33950/#review82862
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 7, 2015, 6:20 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33950/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 6:20 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1308
> https://issues.apache.org/jira/browse/AURORA-1308
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references
>
> Patch resets rc version and removes changelog entries, updates changelog script to only pull in relevant issues now
>
>
> Diffs
> -----
>
> CHANGELOG 3bc43e10792bc8345e5a29631a4e5248926fdc25
> build-support/release/changelog 31fa72dfd850163a7603edcf286099f1bd280d4f
> src/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638
>
> Diff: https://reviews.apache.org/r/33950/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 33950: Fix 0.8.0-RC0 issues raised due to changelog
containing wontfix and duplicate ticket references
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33950/#review82902
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On May 7, 2015, 1:56 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33950/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 1:56 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1308
> https://issues.apache.org/jira/browse/AURORA-1308
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references
>
> Patch resets rc version and removes changelog entries, updates changelog script to only pull in relevant issues now
>
>
> Diffs
> -----
>
> CHANGELOG 3bc43e10792bc8345e5a29631a4e5248926fdc25
> build-support/release/changelog 31fa72dfd850163a7603edcf286099f1bd280d4f
> src/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638
>
> Diff: https://reviews.apache.org/r/33950/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 33950: Fix 0.8.0-RC0 issues raised due to changelog
containing wontfix and duplicate ticket references
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33950/
-----------------------------------------------------------
(Updated May 7, 2015, 8:56 p.m.)
Review request for Aurora and Bill Farner.
Summary (updated)
-----------------
Fix 0.8.0-RC0 issues raised due to changelog containing wontfix and duplicate ticket references
Bugs: AURORA-1308
https://issues.apache.org/jira/browse/AURORA-1308
Repository: aurora
Description
-------
AURORA-1308 - 0.8.0 changelog contains wontfix and duplicate ticket references
Patch resets rc version and removes changelog entries, updates changelog script to only pull in relevant issues now
Diffs
-----
CHANGELOG 3bc43e10792bc8345e5a29631a4e5248926fdc25
build-support/release/changelog 31fa72dfd850163a7603edcf286099f1bd280d4f
src/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638
Diff: https://reviews.apache.org/r/33950/diff/
Testing
-------
Thanks,
Jake Farrell