You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2021/04/20 11:01:47 UTC

[camel] branch master updated: CAMEL-16400: adjust manual integration tests for camel-ldif (#5443)

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new 6d3724b  CAMEL-16400: adjust manual integration tests for camel-ldif (#5443)
6d3724b is described below

commit 6d3724b3365ea2454d1c2817c269fc71409e1a6a
Author: Otavio Rodolfo Piske <or...@users.noreply.github.com>
AuthorDate: Tue Apr 20 13:01:23 2021 +0200

    CAMEL-16400: adjust manual integration tests for camel-ldif (#5443)
---
 components/camel-ldif/pom.xml                       | 21 ---------------------
 .../ldif/{LdifRouteTest.java => LdifRouteIT.java}   |  5 ++++-
 2 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/components/camel-ldif/pom.xml b/components/camel-ldif/pom.xml
index 77c81f3..852911d 100644
--- a/components/camel-ldif/pom.xml
+++ b/components/camel-ldif/pom.xml
@@ -90,25 +90,4 @@
             <scope>test</scope>
         </dependency>
     </dependencies>
-
-    <!-- the tests does not work - due to complex ldap server tests - maybe try with testcontainers with existing ldap server -->
-    <profiles>
-        <profile>
-            <id>ldap-skip-tests</id>
-            <activation>
-                <activeByDefault>true</activeByDefault>
-            </activation>
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <skipTests>true</skipTests>
-                        </configuration>
-                    </plugin>
-                </plugins>
-            </build>
-        </profile>
-    </profiles>
-
 </project>
diff --git a/components/camel-ldif/src/test/java/org/apache/camel/component/ldif/LdifRouteTest.java b/components/camel-ldif/src/test/java/org/apache/camel/component/ldif/LdifRouteIT.java
similarity index 97%
rename from components/camel-ldif/src/test/java/org/apache/camel/component/ldif/LdifRouteTest.java
rename to components/camel-ldif/src/test/java/org/apache/camel/component/ldif/LdifRouteIT.java
index 9b02ed4..f7f7dbf 100644
--- a/components/camel-ldif/src/test/java/org/apache/camel/component/ldif/LdifRouteTest.java
+++ b/components/camel-ldif/src/test/java/org/apache/camel/component/ldif/LdifRouteIT.java
@@ -44,6 +44,7 @@ import org.apache.directory.server.core.integ5.DirectoryExtension;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.EnabledIfSystemProperty;
 import org.junit.jupiter.api.extension.ExtendWith;
 
 import static org.apache.directory.server.integ.ServerIntegrationUtils.getWiredConnection;
@@ -56,7 +57,9 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 @ExtendWith(DirectoryExtension.class)
 @CreateLdapServer(transports = { @CreateTransport(protocol = "LDAP") })
-public class LdifRouteTest extends AbstractLdapTestUnit {
+@EnabledIfSystemProperty(named = "enable.ldif.itests", matches = "true",
+                         disabledReason = "the tests does not work due to complex ldap server environment")
+public class LdifRouteIT extends AbstractLdapTestUnit {
     // Constants
     private static final String LDAP_CONN_NAME = "conn";
     private static final String ENDPOINT_LDIF = "ldif:" + LDAP_CONN_NAME;