You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 09:29:32 UTC
[jira] [Created] (BOOKKEEPER-97) collect pub/sub/consume statistics
on hub server
collect pub/sub/consume statistics on hub server
------------------------------------------------
Key: BOOKKEEPER-97
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Sijie Guo
collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-97) collect pub/sub/consume statistics
on hub server
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-97:
--------------------------------
Attachment: BK-97.diff_v3
new patch fix typo.
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BK-97.diff_v2, BK-97.diff_v3, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231253#comment-13231253 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-97:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/#review6037
-----------------------------------------------------------
Ship it!
+1 looks fine to me.
- fpj
On 2012-03-13 11:36:29, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4308/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 11:36:29)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. collecting pub/sub/consume statistics on hub server and expose them thru JMX.
bq.
bq. the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing statistics thru JMX.
bq.
bq.
bq. This addresses bug BOOKKEEPER-97.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-97
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 2c9af4d
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 2573df0
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java 1712027
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java 7a785c4
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java f3b108a
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java 09e8b92
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 27e3104
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 2f896d2
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 0261521
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4308/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-97) collect pub/sub/consume statistics
on hub server
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-97:
--------------------------------
Attachment: BOOKKEEPER-97.patch
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Attachments: BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231998#comment-13231998 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-97:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/
-----------------------------------------------------------
(Updated 2012-03-17 16:08:39.341388)
Review request for bookkeeper.
Changes
-------
fix typo.
Summary
-------
collecting pub/sub/consume statistics on hub server and expose them thru JMX.
the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing statistics thru JMX.
This addresses bug BOOKKEEPER-97.
https://issues.apache.org/jira/browse/BOOKKEEPER-97
Diffs (updated)
-----
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java f3b108a
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java 09e8b92
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 27e3104
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java 7a785c4
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 2c9af4d
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 2573df0
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java 1712027
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 2f896d2
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 5782bba
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java PRE-CREATION
Diff: https://reviews.apache.org/r/4308/diff
Testing
-------
Thanks,
Sijie
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231068#comment-13231068 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-97:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/#review6030
-----------------------------------------------------------
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java
<https://reviews.apache.org/r/4308/#comment13012>
typo, should be getNumMessagesDelivered()
- Ivan
On 2012-03-13 11:36:29, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4308/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 11:36:29)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. collecting pub/sub/consume statistics on hub server and expose them thru JMX.
bq.
bq. the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing statistics thru JMX.
bq.
bq.
bq. This addresses bug BOOKKEEPER-97.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-97
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 2c9af4d
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 2573df0
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java 1712027
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java 7a785c4
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java f3b108a
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java 09e8b92
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 27e3104
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 2f896d2
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 0261521
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4308/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232581#comment-13232581 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-97:
---------------------------------------------------------
bq. On 2012-03-19 12:07:58, Ivan Kelly wrote:
bq. > hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java, line 175
bq. > <https://reviews.apache.org/r/4308/diff/1-2/?file=91622#file91622line175>
bq. >
bq. > Another typo here, thouls be incrementMessagesDelivered
ah, will fix it.
bq. On 2012-03-19 12:07:58, Ivan Kelly wrote:
bq. > hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java, line 260
bq. > <https://reviews.apache.org/r/4308/diff/1-2/?file=91624#file91624line260>
bq. >
bq. > This seems to be from another patch?
diff 1 is old, diff 2 is newer, when you read diffs between 1 and 2, you saw this. actually it is not in the patch.
- Sijie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/#review6068
-----------------------------------------------------------
On 2012-03-17 16:08:39, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4308/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-17 16:08:39)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. collecting pub/sub/consume statistics on hub server and expose them thru JMX.
bq.
bq. the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing statistics thru JMX.
bq.
bq.
bq. This addresses bug BOOKKEEPER-97.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-97
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java f3b108a
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java 09e8b92
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 27e3104
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java 7a785c4
bq. hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 2c9af4d
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 2573df0
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java 1712027
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 2f896d2
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 5782bba
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4308/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BK-97.diff_v2, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-97) collect pub/sub/consume statistics
on hub server
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-97:
--------------------------------
Attachment: BK-97.diff
new patch rebased on trunk. it also include BOOKKEEPER-99, exposing the statistics thru JMX.
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Attachments: BK-97.diff, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241177#comment-13241177 ]
Hudson commented on BOOKKEEPER-97:
----------------------------------
Integrated in bookkeeper-trunk #431 (See [https://builds.apache.org/job/bookkeeper-trunk/431/])
BOOKKEEPER-97: collect pub/sub/consume statistics on hub server (sijie via ivank) (Revision 1306798)
Result = SUCCESS
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BK-97.diff_v2, BK-97.diff_v3, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-97) collect pub/sub/consume statistics
on hub server
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-97:
--------------------------------
Attachment: BK-97.diff_v2
new patch fix typo.
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BK-97.diff_v2, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232579#comment-13232579 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-97:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/#review6068
-----------------------------------------------------------
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java
<https://reviews.apache.org/r/4308/#comment13047>
Another typo here, thouls be incrementMessagesDelivered
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
<https://reviews.apache.org/r/4308/#comment13046>
This seems to be from another patch?
- Ivan
On 2012-03-17 16:08:39, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4308/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-17 16:08:39)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. collecting pub/sub/consume statistics on hub server and expose them thru JMX.
bq.
bq. the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing statistics thru JMX.
bq.
bq.
bq. This addresses bug BOOKKEEPER-97.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-97
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java f3b108a
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java 09e8b92
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 27e3104
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java 7a785c4
bq. hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 2c9af4d
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 2573df0
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java 1712027
bq. hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 2f896d2
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 5782bba
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java PRE-CREATION
bq. hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4308/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BK-97.diff_v2, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232638#comment-13232638 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-97:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/
-----------------------------------------------------------
(Updated 2012-03-19 14:29:14.025687)
Review request for bookkeeper.
Changes
-------
fix typo
Summary
-------
collecting pub/sub/consume statistics on hub server and expose them thru JMX.
the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing statistics thru JMX.
This addresses bug BOOKKEEPER-97.
https://issues.apache.org/jira/browse/BOOKKEEPER-97
Diffs (updated)
-----
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 2c9af4d
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 2573df0
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java 1712027
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java 7a785c4
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java f3b108a
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java 09e8b92
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 27e3104
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 2f896d2
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 5782bba
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java PRE-CREATION
Diff: https://reviews.apache.org/r/4308/diff
Testing
-------
Thanks,
Sijie
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-97.diff, BK-97.diff_v2, BK-97.diff_v3, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-97) collect pub/sub/consume
statistics on hub server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228332#comment-13228332 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-97:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4308/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
collecting pub/sub/consume statistics on hub server and expose them thru JMX.
the patch is based on BOOKKEEPER-96, includes BOOKKEEPER-99, exposing statistics thru JMX.
This addresses bug BOOKKEEPER-97.
https://issues.apache.org/jira/browse/BOOKKEEPER-97
Diffs
-----
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 2c9af4d
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/BaseHandler.java 2573df0
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/ConsumeHandler.java 1712027
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerMXBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/PublishHandler.java 7a785c4
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java f3b108a
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/UnsubscribeHandler.java 09e8b92
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 27e3104
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServerMXBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 2f896d2
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 0261521
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheBean.java PRE-CREATION
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCacheMXBean.java PRE-CREATION
Diff: https://reviews.apache.org/r/4308/diff
Testing
-------
Thanks,
Sijie
> collect pub/sub/consume statistics on hub server
> ------------------------------------------------
>
> Key: BOOKKEEPER-97
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-97
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Attachments: BK-97.diff, BOOKKEEPER-97.patch
>
>
> collecting pub/sub/consume statistics on hub server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira