You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/03/11 18:17:15 UTC
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------
(Updated March 11, 2016, 5:17 p.m.)
Review request for Ambari, Daniel Gergely, Jaimin Jetly, Laszlo Puskas, and Yusaku Sako.
Changes
-------
added branch-2.2 & fix issues during manual testing
Bugs: AMBARI-12931
https://issues.apache.org/jira/browse/AMBARI-12931
Repository: ambari
Description
-------
Problem:
- Corrupted Block metric on the UI means corrupted replicas.
Solution:
- In fact this metric comes from hadoop:
FSNamesystem.java:
@Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
public long getCorruptReplicaBlocks() {
return blockManager.getCorruptReplicaBlocksCount();
}
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 78cf8bd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 89aab13
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json ee745d9
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java f6dcb18
ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
ambari-web/app/messages.js 6b8317b
Diff: https://reviews.apache.org/r/38095/diff/
Testing
-------
Unit testing done.
Thanks,
Oliver Szabo