You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jujoramos (GitHub)" <gi...@apache.org> on 2019/01/30 11:54:42 UTC
[GitHub] [geode] jujoramos opened pull request #3138: GEODE-6293: Fix
fire & forget functions in gfsh
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3138 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jujoramos commented on issue #3138: GEODE-6293: Fix
fire & forget functions in gfsh
Posted by "jujoramos (GitHub)" <gi...@apache.org>.
Commit [f99fd8d](https://github.com/apache/geode/pull/3138/commits/f99fd8d91f3fd09e24aadbe5c1b2424bbc1e9f02) contains the core changes to fix the issue, commit [242e20a](https://github.com/apache/geode/pull/3138/commits/242e20a00efa00e249b2ec2c8b324519b7d7e153) is basically the refactoring and extra testing. Once the changes are approved I'll squash both commits before merging them into `develop`.
[ Full content available at: https://github.com/apache/geode/pull/3138 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jujoramos commented on issue #3138: GEODE-6293: Fix
fire & forget functions in gfsh
Posted by "jujoramos (GitHub)" <gi...@apache.org>.
Commit [f99fd8d](https://github.com/apache/geode/pull/3138/commits/f99fd8d91f3fd09e24aadbe5c1b2424bbc1e9f02) contains the core changes to fix the issue, commit [242e20a](https://github.com/apache/geode/pull/3138/commits/242e20a00efa00e249b2ec2c8b324519b7d7e153) the refactor and extra testing. Once the changes are approved I'll squash both commits before merging them into `develop`.
[ Full content available at: https://github.com/apache/geode/pull/3138 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jujoramos closed pull request #3138: GEODE-6293: Fix
fire & forget functions in gfsh
Posted by "jujoramos (GitHub)" <gi...@apache.org>.
[ pull request closed by jujoramos ]
[ Full content available at: https://github.com/apache/geode/pull/3138 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org