[GitHub] [druid] ccaominh commented on a change in pull request #9334: Web console: Column counter

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #9334: Web console: Column counter
URL: https://github.com/apache/druid/pull/9334#discussion_r376738307
 
 

 ##########
 File path: web-console/src/components/table-column-selector/__snapshots__/table-column-selector.spec.tsx.snap
 ##########
 @@ -14,7 +14,12 @@ exports[`table column matches snapshot 1`] = `
       <span
         class="bp3-button-text"
       >
-        Columns
+        Columns 
+        <span
+          class="counter"
+        >
+          (0/3)
 
 Review comment:
   May be worth it for the test to validate a scenario where some of the columns are shown

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org