Re: [PR] fix(echarts): reserve grid room for Gantt category names [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #43189:
URL: https://github.com/apache/superset/pull/43189#issuecomment-5545954830

   Nice approach on the cap + truncation, @bikash-barnwal. 
   
   `measureTextWidth` measures at `theme.fontSizeSM` (series.ts), but the markLine label in transformProps.ts only sets `color`, no `fontSize`. If it renders at a different size than fontSizeSM, the reserved width won't match the real label and we could still clip (or over-truncate) for some themes. Can you confirm those line up, or pass the label's actual font size into the measurement? 
   
   Also, `TEXT_WIDTH_CACHE` is unbounded and now keyed on Gantt category names instead of just legend labels, which could be much higher cardinality over a long session, worth capping while you're in there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org