[GitHub] busbey commented on a change in pull request #944: Upgrade process should not assume the administrative user is named 'root'.

[GitBox <gi...@apache.org>]

busbey commented on a change in pull request #944: Upgrade process should not assume the administrative user is named 'root'.
URL: https://github.com/apache/accumulo/pull/944#discussion_r255158352
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/Master.java
 ##########
 @@ -459,8 +464,11 @@ private void upgradeZookeeper() {
           perm.grantNamespacePermission(user, Namespaces.ACCUMULO_NAMESPACE_ID,
               NamespacePermission.READ);
         }
-        perm.grantNamespacePermission("root", Namespaces.ACCUMULO_NAMESPACE_ID,
-            NamespacePermission.ALTER_TABLE);
+        // because we need to refer to the root username, we can't use the
+        // ZKPermHandler directly. The security object should work since
 
 Review comment:
   ```suggestion
           // ZKPermHandler directly since that violates our earlier assumption that we don't
           // care about contents of the username. PermissionHandlers that need to
           // encode the username in some way, i.e. the KerberosPermissionHandler, things would
           // fail. Instead we should be able to use the security object since
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services