You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Prakash Khemani (Created) (JIRA)" <ji...@apache.org> on 2011/12/02 07:37:40 UTC

[jira] [Created] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Block cache can be mistakenly instantiated by tools
---------------------------------------------------

                 Key: HBASE-4932
                 URL: https://issues.apache.org/jira/browse/HBASE-4932
             Project: HBase
          Issue Type: Bug
            Reporter: Prakash Khemani


Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161450#comment-13161450 ] 

stack commented on HBASE-4932:
------------------------------

Yeah.  This is actually a pain.   Master splitting WALs used to be creating blockcaches until ugly-hacked it not too.
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163153#comment-13163153 ] 

Nicolas Spiegelberg commented on HBASE-4932:
--------------------------------------------

looks good for now. sounds like we need to clean up the caching semantics for a writer in trunk :\ Save that for another JIRA
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234578#comment-13234578 ] 

Lars Hofhansl commented on HBASE-4932:
--------------------------------------

Is this ready for commit to 0.94?
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163175#comment-13163175 ] 

stack commented on HBASE-4932:
------------------------------

I was going to say this is probably really expensive but its just cloning of in memory Arrays and Properties so probably not too bad:

{code}
-  public static final WriterFactory getWriterFactory(Configuration conf) {
-    return HFile.getWriterFactory(conf, new CacheConfig(conf));
+  public static final WriterFactory getWriterFactoryNoCache(Configuration
+       conf) {
+    Configuration tempConf = new Configuration(conf);
+    tempConf.setFloat(CacheConfig.HFILE_BLOCK_CACHE_SIZE_KEY, 0.0f);
+    return HFile.getWriterFactory(conf, new CacheConfig(tempConf));
{code}


+1 on patch.


                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-4932:
---------------------------------------

    Comment: was deleted

(was: looks good for now. sounds like we need to clean up the caching semantics for a writer in trunk :\ Save that for another JIRA)
    
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Mikhail Bautin (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215864#comment-13215864 ] 

Mikhail Bautin commented on HBASE-4932:
---------------------------------------

@Prakash: I've noticed that this is not there in 89-fb. Do we need this patch there as well?
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163149#comment-13163149 ] 

Nicolas Spiegelberg commented on HBASE-4932:
--------------------------------------------

Phabricator is being a little buggy.  Working with Marek to diagnose the problem.  See https://reviews.facebook.net/D573
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169815#comment-13169815 ] 

Hadoop QA commented on HBASE-4932:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506185/HBASE-4932.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 25 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/511//console

This message is automatically generated.
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Prakash Khemani (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prakash Khemani reassigned HBASE-4932:
--------------------------------------

    Assignee: Prakash Khemani
    
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163152#comment-13163152 ] 

Nicolas Spiegelberg commented on HBASE-4932:
--------------------------------------------

looks good for now. sounds like we need to clean up the caching semantics for a writer in trunk :\ Save that for another JIRA
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163232#comment-13163232 ] 

Hudson commented on HBASE-4932:
-------------------------------

Integrated in HBase-TRUNK #2519 (See [https://builds.apache.org/job/HBase-TRUNK/2519/])
    HBASE-4932 Block cache can be mistakenly instantiated by tools

Summary: disable block cache for HFile writers created for tools

Test Plan:
ran the following tests that call getWriterFactory

test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java
test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java
test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java

Reviewers: dhruba, jgray, nspiegelberg, JIRA, mbautin

Reviewed By: nspiegelberg

CC: HBase Diffs Facebook Group, mbautin, khemani, nspiegelberg

Differential Revision: 573

nspiegelberg : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java

                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-4932:
---------------------------------------

    Fix Version/s: 0.94.0
           Status: Patch Available  (was: Open)
    
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-4932:
---------------------------------------

    Attachment: HBASE-4932.patch
    
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-4932:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.96.0
           Status: Resolved  (was: Patch Available)

Ah, NM, was already committed, just not marked fixed.
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163165#comment-13163165 ] 

Hadoop QA commented on HBASE-4932:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506185/HBASE-4932.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 25 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/449//console

This message is automatically generated.
                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163371#comment-13163371 ] 

Hudson commented on HBASE-4932:
-------------------------------

Integrated in HBase-TRUNK-security #23 (See [https://builds.apache.org/job/HBase-TRUNK-security/23/])
    HBASE-4932 Block cache can be mistakenly instantiated by tools

Summary: disable block cache for HFile writers created for tools

Test Plan:
ran the following tests that call getWriterFactory

test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java
test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
test/java/org/apache/hadoop/hbase/io/hfile/TestReseekTo.java
test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
test/java/org/apache/hadoop/hbase/io/TestHalfStoreFileReader.java
test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java

Reviewers: dhruba, jgray, nspiegelberg, JIRA, mbautin

Reviewed By: nspiegelberg

CC: HBase Diffs Facebook Group, mbautin, khemani, nspiegelberg

Differential Revision: 573

nspiegelberg : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFilePerformance.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java

                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4932) Block cache can be mistakenly instantiated by tools

Posted by "Prakash Khemani (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215947#comment-13215947 ] 

Prakash Khemani commented on HBASE-4932:
----------------------------------------

Yes ... It is a good to have patch. Thanks.

On 2/24/12 12:03 PM, "Mikhail Bautin (Commented) (JIRA)" <ji...@apache.org>



                
> Block cache can be mistakenly instantiated by tools
> ---------------------------------------------------
>
>                 Key: HBASE-4932
>                 URL: https://issues.apache.org/jira/browse/HBASE-4932
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4932.patch
>
>
> Map Reduce tasks that create a writer to write HFiles inadvertently end up creating block cache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira