You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/11/17 05:05:40 UTC
[kudu-CR] KUDU-1722 - Range Partition Failure on UNIXTIME MICROS
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5119
Change subject: KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
......................................................................
KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
Errors are returned when attempting to add range partition bounds
for a unixtime_micros value when specifying bound types that are
not the default. This is happening because the logic to convert the
bounds to defaults (inclusive for Lower and exclusive for Upper)
converts the UNIXTIME_MICROS value to an INT64. This patch addresses
this issue and includes a test.
Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
---
M src/kudu/client/client-test.cc
M src/kudu/common/partition.cc
2 files changed, 38 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/5119/1
--
To view, visit http://gerrit.cloudera.org:8080/5119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
[kudu-CR] KUDU-1722 - Range Partition Failure on UNIXTIME MICROS
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has submitted this change and it was merged.
Change subject: KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
......................................................................
KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
Errors are returned when attempting to add range partition bounds
for a unixtime_micros value when specifying bound types that are
not the default. This is happening because the logic to convert the
bounds to defaults (inclusive for Lower and exclusive for Upper)
converts the UNIXTIME_MICROS value to an INT64. This patch addresses
this issue and includes a test.
Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
Reviewed-on: http://gerrit.cloudera.org:8080/5119
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/client/client-test.cc
M src/kudu/common/partition.cc
2 files changed, 39 insertions(+), 3 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1722 - Range Partition Failure on UNIXTIME MICROS
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5119
to look at the new patch set (#3).
Change subject: KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
......................................................................
KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
Errors are returned when attempting to add range partition bounds
for a unixtime_micros value when specifying bound types that are
not the default. This is happening because the logic to convert the
bounds to defaults (inclusive for Lower and exclusive for Upper)
converts the UNIXTIME_MICROS value to an INT64. This patch addresses
this issue and includes a test.
Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
---
M src/kudu/client/client-test.cc
M src/kudu/common/partition.cc
2 files changed, 39 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/5119/3
--
To view, visit http://gerrit.cloudera.org:8080/5119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1722 - Range Partition Failure on UNIXTIME MICROS
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5119
to look at the new patch set (#4).
Change subject: KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
......................................................................
KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
Errors are returned when attempting to add range partition bounds
for a unixtime_micros value when specifying bound types that are
not the default. This is happening because the logic to convert the
bounds to defaults (inclusive for Lower and exclusive for Upper)
converts the UNIXTIME_MICROS value to an INT64. This patch addresses
this issue and includes a test.
Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
---
M src/kudu/client/client-test.cc
M src/kudu/common/partition.cc
2 files changed, 39 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/5119/4
--
To view, visit http://gerrit.cloudera.org:8080/5119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1722 - Range Partition Failure on UNIXTIME MICROS
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5119
to look at the new patch set (#2).
Change subject: KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
......................................................................
KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
Errors are returned when attempting to add range partition bounds
for a unixtime_micros value when specifying bound types that are
not the default. This is happening because the logic to convert the
bounds to defaults (inclusive for Lower and exclusive for Upper)
converts the UNIXTIME_MICROS value to an INT64. This patch addresses
this issue and includes a test.
Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
---
M src/kudu/client/client-test.cc
M src/kudu/common/partition.cc
2 files changed, 39 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/5119/2
--
To view, visit http://gerrit.cloudera.org:8080/5119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1722 - Range Partition Failure on UNIXTIME MICROS
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1722 - Range Partition Failure on UNIXTIME_MICROS
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47d23d184a6b73c5c0cdd04519821c4e7eb53ecb
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No