You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/06/13 00:31:48 UTC
Review Request 22541: Request and Stage should not throw RuntimeException
when cluster could not be loaded
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22541/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-6105
https://issues.apache.org/jira/browse/AMBARI-6105
Repository: ambari
Description
-------
Steps to reproduce:
* Install cluster, and service install (Nagios) fails
* Return to de-select Nagios
* Continue to install, everything green
* Restart ambari-server, and get error 500: Cluster <id> not found
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java d1b7e5c
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 98ca13b
Diff: https://reviews.apache.org/r/22541/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:24.685s
[INFO] Finished at: Thu Jun 12 18:21:40 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 22541: Request and Stage should not throw
RuntimeException when cluster could not be loaded
Posted by Nate Cole <nc...@hortonworks.com>.
> On June 12, 2014, 6:47 p.m., Sid Wagle wrote:
> > The change looks good but will this affect the Blueprint creation in any way? We do have a ClusterNotFoundException, does it makes sense to use that here ?
No, the error condition would have propagated for failed blueprint installs too. It was my decoupling of resources from clusters that added this breakage in the first place
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22541/#review45547
-----------------------------------------------------------
On June 12, 2014, 6:31 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22541/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 6:31 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-6105
> https://issues.apache.org/jira/browse/AMBARI-6105
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps to reproduce:
> * Install cluster, and service install (Nagios) fails
> * Return to de-select Nagios
> * Continue to install, everything green
> * Restart ambari-server, and get error 500: Cluster <id> not found
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java d1b7e5c
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 98ca13b
>
> Diff: https://reviews.apache.org/r/22541/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:24.685s
> [INFO] Finished at: Thu Jun 12 18:21:40 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 22541: Request and Stage should not throw
RuntimeException when cluster could not be loaded
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22541/#review45547
-----------------------------------------------------------
The change looks good but will this affect the Blueprint creation in any way? We do have a ClusterNotFoundException, does it makes sense to use that here ?
- Sid Wagle
On June 12, 2014, 10:31 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22541/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 10:31 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-6105
> https://issues.apache.org/jira/browse/AMBARI-6105
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps to reproduce:
> * Install cluster, and service install (Nagios) fails
> * Return to de-select Nagios
> * Continue to install, everything green
> * Restart ambari-server, and get error 500: Cluster <id> not found
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java d1b7e5c
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 98ca13b
>
> Diff: https://reviews.apache.org/r/22541/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:24.685s
> [INFO] Finished at: Thu Jun 12 18:21:40 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 22541: Request and Stage should not throw
RuntimeException when cluster could not be loaded
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22541/#review45623
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On June 13, 2014, 1:58 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22541/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 1:58 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-6105
> https://issues.apache.org/jira/browse/AMBARI-6105
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps to reproduce:
> * Install cluster, and service install (Nagios) fails
> * Return to de-select Nagios
> * Continue to install, everything green
> * Restart ambari-server, and get error 500: Cluster <id> not found
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java d1b7e5c
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 98ca13b
>
> Diff: https://reviews.apache.org/r/22541/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:24.685s
> [INFO] Finished at: Thu Jun 12 18:21:40 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 22541: Request and Stage should not throw
RuntimeException when cluster could not be loaded
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22541/
-----------------------------------------------------------
(Updated June 13, 2014, 9:58 a.m.)
Review request for Ambari and Sid Wagle.
Changes
-------
Updated patch to change from LOG.error to LOG.debug (log gets filled up fast in the case of that initial failure).
Bugs: AMBARI-6105
https://issues.apache.org/jira/browse/AMBARI-6105
Repository: ambari
Description
-------
Steps to reproduce:
* Install cluster, and service install (Nagios) fails
* Return to de-select Nagios
* Continue to install, everything green
* Restart ambari-server, and get error 500: Cluster <id> not found
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java d1b7e5c
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 98ca13b
Diff: https://reviews.apache.org/r/22541/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:24.685s
[INFO] Finished at: Thu Jun 12 18:21:40 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole