You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "djanderson (via GitHub)" <gi...@apache.org> on 2024/07/25 19:29:05 UTC

[I] Support DoPutStatementIngest from Arrow Flight SQL 17.0 [arrow-rs]

djanderson opened a new issue, #6124:
URL: https://github.com/apache/arrow-rs/issues/6124

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   I have a Flight server that I'm working to cut over to Flight SQL. The bulk ingest (equivalent of `do_put`) has been a challenge. 
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   I noticed that the current stable version of the Flight SQL protobuf definition ([17.0](https://arrow.apache.org/docs/format/FlightSql.html)) defines a new `CommandStatementIngest` that looks like it would do exactly what I need to do.
   
   I believe we would need to 
   - Regen the protobuf definitions for the currently stable 17.0
   - Add a new method to the `FlightSqlService` trait: `do_put_statement_ingest`
   - Add a new branch to the match statement to match `CommandStatementIngest`
   - Update examples
   
   ```rust
       async fn do_put_statement_ingest(
           &self,
           ticket: CommandStatementIngest,
           request: Request<PeekableFlightDataStream>,
       ) -> Result<DoPutUpdateResult, Status> {
           info!("do_put_statement_update");
           Err(Status::unimplemented("Implement do_put_statement_update"))
       }
   ```
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   I'm happy to work on a patch but I'm not sure if this would need to be part of a bigger update to fully support Flight SQL 17.0. I haven't done a diff of the specs to understand all the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support DoPutStatementIngest from Arrow Flight SQL 17.0 [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6124:
URL: https://github.com/apache/arrow-rs/issues/6124#issuecomment-2322898656

   `label_issue.py` automatically added labels {'arrow-flight'} from #6133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support DoPutStatementIngest from Arrow Flight SQL 17.0 [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6124: Support DoPutStatementIngest from Arrow Flight SQL 17.0
URL: https://github.com/apache/arrow-rs/issues/6124


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support DoPutStatementIngest from Arrow Flight SQL 17.0 [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6124:
URL: https://github.com/apache/arrow-rs/issues/6124#issuecomment-2322898646

   `label_issue.py` automatically added labels {'arrow'} from #6133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Support DoPutStatementIngest from Arrow Flight SQL 17.0 [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6124:
URL: https://github.com/apache/arrow-rs/issues/6124#issuecomment-2252666851

   Thanks @djanderson  -- this sounds like a good plan to me, and good timing as well -- we have a release planned in about a month that can take breaking changes so we should be able to get this change in by then
   
   I think you have identified the major pieces. If possible it would be helpful to break it into multiple smaller PRs. Perhaps something like:
   1. Update the protobuf definitions
   2. Update the FligthSql service / add example
   
   Thanks again for the offer -- this sounds great


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org