[GitHub] [calcite] ambition119 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

[GitBox <gi...@apache.org>]

ambition119 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT
URL: https://github.com/apache/calcite/pull/1168#discussion_r285952439
 
 

 ##########
 File path: site/_docs/reference.md
 ##########
 @@ -1483,12 +1483,12 @@ period:
 | {fn UCASE(string)} | Returns a string in which all alphabetic characters in *string* have been converted to upper case
 | {fn REPLACE(string, search, replacement)} | Returns a string in which all the occurrences of *search* in *string* are replaced with *replacement*; if *replacement* is the empty string, the occurrences of *search* are removed
 | {fn ASCII(string)} | Returns the corresponding ASCII code of the first character of *string*; Returns 0 if *string* is empty; Returns NULL if *string* is NULL; Returns the Unicode code point for non-ASCII character
+| {fn LEFT(string, integer)} | Returns the leftmost len characters from the *string*; Returns NULL if *string* is NULL;
+| {fn RIGHT(string, integer)} | Returns the rightmost len characters from the *string*; Returns NULL if *string* is NULL;
 
 Review comment:
   JDBC String function `{fn LEFT(string, integer)` and `{fn RIGHT(string, integer)}`  not create in `SqlJdbcFunctionCall` and `SqlOperatorBaseTest.testJdbcFn()` not test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services