[GitHub] [airflow] Taragolis commented on a diff in pull request #28459: Migrate remaining Always & CLI tests to `pytest`

[GitBox <gi...@apache.org>]

Taragolis commented on code in PR #28459:
URL: https://github.com/apache/airflow/pull/28459#discussion_r1052116651


##########
tests/always/test_project_structure.py:
##########
@@ -30,68 +30,79 @@
 )
 
 
-class TestProjectStructure(unittest.TestCase):
+class TestProjectStructure:

Review Comment:
   I thought `TestProjectStructure` should be re-worked, I miss the main idea of this test so it would be nice if someone could share the idea about this tests
   
   ---
   
   `test_deprecated_packages` - I thought this test not properly worked since actual files replaced by PEP-562 getattr - https://github.com/apache/airflow/pull/26153
   
   ---
   
   `test_providers_modules_should_have_tests` - This test broken for a while, generators wrapped into generators and when it actually transformed to set this line broke `expected_test_files` calculation and it always `set([])`
   https://github.com/apache/airflow/blob/e377e869da9f0e42ac1e0a615347cf7cd6565d54/tests/always/test_project_structure.py#L87
   
   Rather than raise an error in this test, I add print warning instead of until we fix or rewrite this test logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org