You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/29 04:32:00 UTC
[jira] [Commented] (YARN-7578) Extend
TestDiskFailures.waitForDiskHealthCheck() sleeping time.
[ https://issues.apache.org/jira/browse/YARN-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270120#comment-16270120 ]
ASF GitHub Bot commented on YARN-7578:
--------------------------------------
GitHub user vetriselvan1187 opened a pull request:
https://github.com/apache/hadoop/pull/304
[YARN-7578] waitForDiskHealthCheck sleep time is extended from 1000ms…
… to 1500 ms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vetriselvan1187/hadoop YARN-7578
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit 9efe0fde486737f009b1de5a8458fd580cd0157f
Author: Vetriselvan1187 <ve...@gmail.com>
Date: 2017-11-29T04:25:41Z
[YARN-7578] waitForDiskHealthCheck sleep time is extended from 1000ms to 1500 ms
----
> Extend TestDiskFailures.waitForDiskHealthCheck() sleeping time.
> ---------------------------------------------------------------
>
> Key: YARN-7578
> URL: https://issues.apache.org/jira/browse/YARN-7578
> Project: Hadoop YARN
> Issue Type: Test
> Affects Versions: 3.1.0
> Environment: ARMv8 AArch64, Ubuntu16.04
> Reporter: Guangming Zhang
> Priority: Minor
> Labels: dtest, patch, test
> Fix For: 3.1.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Thread.sleep() function is called to wait for NodeManager to identify disk failures. But in some cases, for example the lower-end hardware computer, the sleep time is too short so that the NodeManager may haven't finished identifying disk failures. This will occur test errors:
> {code:java}
> Running org.apache.hadoop.yarn.server.TestDiskFailures
> Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 17.686 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.TestDiskFailures
> testLocalDirsFailures(org.apache.hadoop.yarn.server.TestDiskFailures) Time elapsed: 10.412 sec <<< FAILURE!
> java.lang.AssertionError: NodeManager could not identify disk failure.
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.apache.hadoop.yarn.server.TestDiskFailures.verifyDisksHealth(TestDiskFailures.java:239)
> at org.apache.hadoop.yarn.server.TestDiskFailures.testDirsFailures(TestDiskFailures.java:186)
> at org.apache.hadoop.yarn.server.TestDiskFailures.testLocalDirsFailures(TestDiskFailures.java:99)
> testLogDirsFailures(org.apache.hadoop.yarn.server.TestDiskFailures) Time elapsed: 5.99 sec <<< FAILURE!
> java.lang.AssertionError: NodeManager could not identify disk failure.
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.apache.hadoop.yarn.server.TestDiskFailures.verifyDisksHealth(TestDiskFailures.java:239)
> at org.apache.hadoop.yarn.server.TestDiskFailures.testDirsFailures(TestDiskFailures.java:186)
> at org.apache.hadoop.yarn.server.TestDiskFailures.testLogDirsFailures(TestDiskFailures.java:111)
> {code}
> So extend the sleep time from 1000ms to 1500ms to avoid some unit test errors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org