You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/30 12:39:24 UTC
[GitHub] [flink] carp84 commented on a change in pull request #9275:
[FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not
compare row type field names and enable blink planner for hbase IT case
carp84 commented on a change in pull request #9275: [FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not compare row type field names and enable blink planner for hbase IT case
URL: https://github.com/apache/flink/pull/9275#discussion_r308689738
##########
File path: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseLookupSourceITCase.java
##########
@@ -200,4 +203,44 @@ public void testHBaseLookupFunction() throws Exception {
StreamITCase.compareWithList(expected);
}
+
+ @Test
+ public void testHBaseLookupTableSource() throws Exception {
+ EnvironmentSettings settings = EnvironmentSettings.newInstance()
+ // only blink planner support lookup table source
+ .useBlinkPlanner().inStreamingMode().build();
Review comment:
We should use parameterized test to both cover blink-planner and flink-planner just like the way in `HBaseSinkITCase`, and remove the `testHBaseLookupFunction` test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services