You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Andreas Hartmann <an...@apache.org> on 2005/08/22 10:35:03 UTC
cocoon.xconf.ant_patch: failonerror=false (was: Re: Reality check
on 1.4x (long))
Hi Lenya devs,
any objections against applying this patch by Angelo Turetta?
-- Andreas
> ------------------------------------------------------------------------
>
> Index: src/targets/publets-build.xml
> ===================================================================
> --- src/targets/publets-build.xml (revision 233325)
> +++ src/targets/publets-build.xml (working copy)
> @@ -50,7 +50,7 @@
> <isfalse value="${cocoon.xconf.isEqual}"/>
> </condition>
> <antcall target="copy-cocoon.xconf"/>
> - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
> + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch" failonerror="false"/>
> </target>
>
> <target name="deploy-publets"
> Index: src/targets/webapp-build.xml
> ===================================================================
> --- src/targets/webapp-build.xml (revision 233325)
> +++ src/targets/webapp-build.xml (working copy)
> @@ -66,7 +66,7 @@
> <isfalse value="${cocoon.xconf.isEqual}"/>
> </condition>
> <antcall target="copy-cocoon.xconf"/>
> - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
> + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch" failonerror="false"/>
>
> <!-- Patch web.xml -->
> <!--
>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: cocoon.xconf.ant_patch: failonerror=false (was: Re: Reality
check on 1.4x (long))
Posted by Thorsten Scherler <th...@apache.org>.
Should be tested whether it is windows.
On linux that behaviour should not be changed IMO.
salu2
On Mon, 2005-08-22 at 10:35 +0200, Andreas Hartmann wrote:
> Hi Lenya devs,
>
> any objections against applying this patch by Angelo Turetta?
>
> -- Andreas
>
>
> > ------------------------------------------------------------------------
> >
> > Index: src/targets/publets-build.xml
> > ===================================================================
> > --- src/targets/publets-build.xml (revision 233325)
> > +++ src/targets/publets-build.xml (working copy)
> > @@ -50,7 +50,7 @@
> > <isfalse value="${cocoon.xconf.isEqual}"/>
> > </condition>
> > <antcall target="copy-cocoon.xconf"/>
> > - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
> > + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch" failonerror="false"/>
> > </target>
> >
> > <target name="deploy-publets"
> > Index: src/targets/webapp-build.xml
> > ===================================================================
> > --- src/targets/webapp-build.xml (revision 233325)
> > +++ src/targets/webapp-build.xml (working copy)
> > @@ -66,7 +66,7 @@
> > <isfalse value="${cocoon.xconf.isEqual}"/>
> > </condition>
> > <antcall target="copy-cocoon.xconf"/>
> > - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
> > + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch" failonerror="false"/>
> >
> > <!-- Patch web.xml -->
> > <!--
> >
> >
> >
> > ------------------------------------------------------------------------
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> > For additional commands, e-mail: dev-help@lenya.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
>
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: cocoon.xconf.ant_patch: failonerror=false
Posted by Oliver Schalch <ol...@wyona.com>.
Andreas Hartmann said the following on 22.08.2005 10:35:
> Hi Lenya devs,
>
> any objections against applying this patch by Angelo Turetta?
At least as a temporary patch its okey, but with that patch the problem,
shouldnt get forgotten why that do not work with the delete tasks.
--
oli
Re: cocoon.xconf.ant_patch: failonerror=false
Posted by Felix Röthenbacher <fe...@wyona.com>.
The reason for using an intermediate file (cocoon.xconf.ant_patch)
for patching the cocoon.xconf was to prevent a reload of cocoon
for minor changes. A reload results in an InitializationException at
this time (I think because of the quartz block).
The file cocoon.xconf.ant_patch doesn't do any harm, so the
deletion step may be omitted if this helps.
- Felix
Doug Chestnut wrote:
> agreed that we need to find the cause, but for now this patch should
> take care of the problem coming up on the mailing list so often. On
> windows I have just commented the lines out and haven't seen any problems.
>
> --Doug
>
> Andreas Hartmann wrote:
>
>> Hi Lenya devs,
>>
>> any objections against applying this patch by Angelo Turetta?
>>
>> -- Andreas
>>
>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: src/targets/publets-build.xml
>>> ===================================================================
>>> --- src/targets/publets-build.xml (revision 233325)
>>> +++ src/targets/publets-build.xml (working copy)
>>> @@ -50,7 +50,7 @@
>>> <isfalse value="${cocoon.xconf.isEqual}"/>
>>> </condition>
>>> <antcall target="copy-cocoon.xconf"/>
>>> - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
>>> + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"
>>> failonerror="false"/>
>>> </target>
>>>
>>> <target name="deploy-publets"
>>> Index: src/targets/webapp-build.xml
>>> ===================================================================
>>> --- src/targets/webapp-build.xml (revision 233325)
>>> +++ src/targets/webapp-build.xml (working copy)
>>> @@ -66,7 +66,7 @@
>>> <isfalse value="${cocoon.xconf.isEqual}"/>
>>> </condition>
>>> <antcall target="copy-cocoon.xconf"/>
>>> - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
>>> + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"
>>> failonerror="false"/>
>>>
>>> <!-- Patch web.xml -->
>>> <!--
>>>
--
Felix Röthenbacher felix.roethenbacher@wyona.com
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: cocoon.xconf.ant_patch: failonerror=false
Posted by Doug Chestnut <dh...@virginia.edu>.
agreed that we need to find the cause, but for now this patch should
take care of the problem coming up on the mailing list so often. On
windows I have just commented the lines out and haven't seen any problems.
--Doug
Andreas Hartmann wrote:
> Hi Lenya devs,
>
> any objections against applying this patch by Angelo Turetta?
>
> -- Andreas
>
>
>> ------------------------------------------------------------------------
>>
>> Index: src/targets/publets-build.xml
>> ===================================================================
>> --- src/targets/publets-build.xml (revision 233325)
>> +++ src/targets/publets-build.xml (working copy)
>> @@ -50,7 +50,7 @@
>> <isfalse value="${cocoon.xconf.isEqual}"/>
>> </condition>
>> <antcall target="copy-cocoon.xconf"/>
>> - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
>> + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"
>> failonerror="false"/>
>> </target>
>>
>> <target name="deploy-publets"
>> Index: src/targets/webapp-build.xml
>> ===================================================================
>> --- src/targets/webapp-build.xml (revision 233325)
>> +++ src/targets/webapp-build.xml (working copy)
>> @@ -66,7 +66,7 @@
>> <isfalse value="${cocoon.xconf.isEqual}"/>
>> </condition>
>> <antcall target="copy-cocoon.xconf"/>
>> - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
>> + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"
>> failonerror="false"/>
>>
>> <!-- Patch web.xml -->
>> <!--
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
>> For additional commands, e-mail: dev-help@lenya.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: cocoon.xconf.ant_patch: failonerror=false (was: Re: Reality
check on 1.4x (long))
Posted by Jann Forrer <ja...@id.unizh.ch>.
On Mon, 22 Aug 2005, Andreas Hartmann wrote:
> Hi Lenya devs,
>
> any objections against applying this patch by Angelo Turetta?
>
+1 but we shoud add a TODO here and declare it is a workaround.
Jann
> -- Andreas
>
>
> > ------------------------------------------------------------------------
> >
> > Index: src/targets/publets-build.xml
> > ===================================================================
> > --- src/targets/publets-build.xml (revision 233325)
> > +++ src/targets/publets-build.xml (working copy)
> > @@ -50,7 +50,7 @@
> > <isfalse value="${cocoon.xconf.isEqual}"/>
> > </condition>
> > <antcall target="copy-cocoon.xconf"/>
> > - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
> > + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch" failonerror="false"/>
> > </target>
> >
> > <target name="deploy-publets"
> > Index: src/targets/webapp-build.xml
> > ===================================================================
> > --- src/targets/webapp-build.xml (revision 233325)
> > +++ src/targets/webapp-build.xml (working copy)
> > @@ -66,7 +66,7 @@
> > <isfalse value="${cocoon.xconf.isEqual}"/>
> > </condition>
> > <antcall target="copy-cocoon.xconf"/>
> > - <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch"/>
> > + <delete file="${build.webapp}/WEB-INF/cocoon.xconf.ant_patch" failonerror="false"/>
> >
> > <!-- Patch web.xml -->
> > <!--
> >
> >
> >
> > ------------------------------------------------------------------------
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> > For additional commands, e-mail: dev-help@lenya.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
>
>
---------------------------------------------------------------
Jann Forrer
Informatikdienste
Universität Zürich
Winterthurerstr. 190
CH-8057 Zuerich
oooO mail: jann.forrer@id.unizh.ch
( ) phone: +41 44 63 56772
\ ( fax: +41 44 63 54505
\_) http://www.id.unizh.ch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org