You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/23 20:16:31 UTC
[kudu-CR] Remove suppression for already-fixed KUDU-189
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5208
to review the following change.
Change subject: Remove suppression for already-fixed KUDU-189
......................................................................
Remove suppression for already-fixed KUDU-189
The code mentioned in this suppression was removed in July 2014
by 0c440b0253e97209c6481608e941e6532db3bd20
Change-Id: I8cd3b917a25cb6d0de7e04d26087cf249f5d00d0
---
M build-support/tsan-suppressions.txt
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/5208/1
--
To view, visit http://gerrit.cloudera.org:8080/5208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cd3b917a25cb6d0de7e04d26087cf249f5d00d0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Remove suppression for already-fixed KUDU-189
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Remove suppression for already-fixed KUDU-189
......................................................................
Remove suppression for already-fixed KUDU-189
The code mentioned in this suppression was removed in July 2014
by 0c440b0253e97209c6481608e941e6532db3bd20
Change-Id: I8cd3b917a25cb6d0de7e04d26087cf249f5d00d0
Reviewed-on: http://gerrit.cloudera.org:8080/5208
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M build-support/tsan-suppressions.txt
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cd3b917a25cb6d0de7e04d26087cf249f5d00d0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Remove suppression for already-fixed KUDU-189
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Remove suppression for already-fixed KUDU-189
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd3b917a25cb6d0de7e04d26087cf249f5d00d0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Remove suppression for already-fixed KUDU-189
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Remove suppression for already-fixed KUDU-189
......................................................................
Patch Set 2: Code-Review+2
Carrying Adar's +2
--
To view, visit http://gerrit.cloudera.org:8080/5208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd3b917a25cb6d0de7e04d26087cf249f5d00d0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No