You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/06/03 16:58:51 UTC

svn commit: r543914 - /jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java

Author: sebb
Date: Sun Jun  3 07:58:51 2007
New Revision: 543914

URL: http://svn.apache.org/viewvc?view=rev&rev=543914
Log:
DateFormat is not thread-safe
Only need one SAXerror handler

Modified:
    jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java

Modified: jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java?view=diff&rev=543914&r1=543913&r2=543914
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java Sun Jun  3 07:58:51 2007
@@ -99,7 +99,8 @@
 
 	private static final Logger log = LoggingManager.getLoggerForClass();
 
-	private static final DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss z"); // ISO format $NON-NLS-1$
+	// N.B. these are not multi-threaded, so don't make it static
+	private final DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss z"); // ISO format $NON-NLS-1$
 	
 	private static final String NL = "\n"; // $NON-NLS-1$
 
@@ -449,7 +450,7 @@
 		xmlButton.setEnabled(true);
 	}
 
-	transient SAXErrorHandler saxErrorHandler = new SAXErrorHandler();
+	private static final SAXErrorHandler saxErrorHandler = new SAXErrorHandler();
 
 	private void showRenderXMLResponse(String response) {
 		String parsable="";



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org