[GitHub] [apisix] kingluo commented on a diff in pull request #9309: fix: proxy-rewrite should set ngx.var.uri

["kingluo (via GitHub)" <gi...@apache.org>]

kingluo commented on code in PR #9309:
URL: https://github.com/apache/apisix/pull/9309#discussion_r1166428037


##########
apisix/plugins/proxy-rewrite.lua:
##########
@@ -317,6 +318,8 @@ function _M.rewrite(conf, ctx)
             upstream_uri = core.utils.uri_safe_encode(upstream_uri)
         end
 
+        req_set_uri(upstream_uri)

Review Comment:
   Note that we don't need to set uri when `use_real_request_uri_unsafe` is true, because in that case, the `upstream_uri` is supposed to take precedence.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org