You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/09 02:51:02 UTC

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5268: [HUDI-3807] Add a new config to control the use of metadata index in HoodieBloomIndex

nsivabalan commented on code in PR #5268:
URL: https://github.com/apache/hudi/pull/5268#discussion_r846565010


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/SparkHoodieBloomIndexHelper.java:
##########
@@ -75,7 +80,9 @@ public static SparkHoodieBloomIndexHelper getInstance() {
         + config.getBloomIndexParallelism() + "}");
 
     JavaRDD<List<HoodieKeyLookupResult>> keyLookupResultRDD;
-    if (config.isMetadataBloomFilterIndexEnabled()) {
+    if (config.getBloomIndexUseMetadata()
+        && getCompletedMetadataPartitions(hoodieTable.getMetaClient().getTableConfig())

Review Comment:
   can we add an api to tableConfig only getCompletedMetadataPartitions(). we can compute once and return the same rather than parsing the table config entry again and again. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org