You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2020/07/23 07:53:12 UTC

[james-project] 01/18: JAMES-3177 extract applicable flags update

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 3ae6ff652fdbea4b08b3ce9a4639b5ff8ef3452a
Author: Matthieu Baechler <ma...@apache.org>
AuthorDate: Tue Jun 16 15:23:07 2020 +0200

    JAMES-3177 extract applicable flags update
---
 .../imap/processor/base/SelectedMailboxImpl.java   | 41 ++++++++++++----------
 1 file changed, 22 insertions(+), 19 deletions(-)

diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java
index 2c07c2a..535e8a5 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/base/SelectedMailboxImpl.java
@@ -365,25 +365,9 @@ public class SelectedMailboxImpl implements SelectedMailbox, MailboxListener {
    
                         }
                     }
-                    
-                    int size = applicableFlags.getUserFlags().length;
-                    FlagsUpdated updatedF = (FlagsUpdated) messageEvent;
-                    List<UpdatedFlags> flags = updatedF.getUpdatedFlags();
-   
-                    for (UpdatedFlags flag : flags) {
-                        applicableFlags.add(flag.getNewFlags());
-   
-                    }
-   
-                    // \RECENT is not a applicable flag in imap so remove it
-                    // from the list
-                    applicableFlags.remove(Flags.Flag.RECENT);
-   
-                    if (size < applicableFlags.getUserFlags().length) {
-                        applicableFlagsChanged = true;
-                    }
-                    
-                    
+
+                    updateApplicableFlags((FlagsUpdated) messageEvent);
+
                 } else if (messageEvent instanceof Expunged) {
                     expungedUids.addAll(messageEvent.getUids());
                     
@@ -396,6 +380,25 @@ public class SelectedMailboxImpl implements SelectedMailbox, MailboxListener {
         }
     }
 
+    private void updateApplicableFlags(FlagsUpdated messageEvent) {
+        int size = applicableFlags.getUserFlags().length;
+        FlagsUpdated updatedF = messageEvent;
+        List<UpdatedFlags> flags = updatedF.getUpdatedFlags();
+
+        for (UpdatedFlags flag : flags) {
+            applicableFlags.add(flag.getNewFlags());
+
+        }
+
+        // \RECENT is not a applicable flag in imap so remove it
+        // from the list
+        applicableFlags.remove(Flag.RECENT);
+
+        if (size < applicableFlags.getUserFlags().length) {
+            applicableFlagsChanged = true;
+        }
+    }
+
     @Override
     public synchronized NullableMessageSequenceNumber msn(MessageUid uid) {
         return uidMsnConverter.getMsn(uid);


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org