You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/08 19:25:42 UTC

[jira] [Commented] (FELIX-5611) BundleRepository must deal properly R5 index file with resources with relative path from the given repository’s URL

    [ https://issues.apache.org/jira/browse/FELIX-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961921#comment-15961921 ] 

ASF GitHub Bot commented on FELIX-5611:
---------------------------------------

GitHub user cvgaviao opened a pull request:

    https://github.com/apache/felix/pull/101

    #FELIX-5611 - BundleRepository must deal properly R5 index file with resources with relative path from the given repository’s URL

    If the url attribute parsed from a resource are relative path then it
    will be resolved against the repository location.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cvgaviao/felix fix_caps_uri_with_relative_path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/felix/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit c94f3acdf6e1452d5d9bbe58d186c48c9391a918
Author: Cristiano Gavião <cv...@gmail.com>
Date:   2017-04-08T19:16:59Z

    #FELIX-5611 - pass repository URL to parsers
    
    If the url attribute parsed from a resource are relative path then it
    will be resolved against the repository location.

----


> BundleRepository must deal properly R5 index file with resources with relative path from the given repository’s URL
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-5611
>                 URL: https://issues.apache.org/jira/browse/FELIX-5611
>             Project: Felix
>          Issue Type: Improvement
>          Components: Bundle Repository (OBR)
>    Affects Versions: bundlerepository-2.0.8
>            Reporter: Cristiano Gavião
>
> I've created some index.xml (R5) files using a tool that was based on old bindex tool. since those files will be hosted in a server the url attribute of bundles and other resources are using relative path (what I think is the right approach since we don't know the real address of the server at this time:
> {quote}
> <repo:capability namespace="osgi.content">
>       <repo:attribute name="osgi.content" value="2ab00a18d414d1c43a7f8ba286f16f323c6b940ca775cdfd974dd6c127a35b25"/>
>       <repo:attribute name="url" value="plugins/ch.qos.logback.core_1.2.1.jar"/>
>       <repo:attribute name="size" type="Long" value="473113"/>
>       <repo:attribute name="mime" value="application/vnd.osgi.bundle"/>
>     </repo:capability>
> {quote}
> But when I try to deploy any bundle using RepositoryAdmin or obr:deploy command, I'm getting an exception: java.net.MalformedURLException: no protocol: plugins/ch.qos.logback.core_1.2.1.jar
> The proposed solution is to pass the URL of the repository to the parser and in case of a non-absolute uri were found it will be resolved against the repository uri.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)